Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: runtime/observatory/lib/src/service/object.dart

Issue 1316123004: Improve display of simd vector types and stack traces in Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.html ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/service/object.dart
diff --git a/runtime/observatory/lib/src/service/object.dart b/runtime/observatory/lib/src/service/object.dart
index 98afa8fad33330667cf96e3960cce4ad9ff2bc15..6efa7fc8cdbba6dfb7130940a936d018eb3b1161 100644
--- a/runtime/observatory/lib/src/service/object.dart
+++ b/runtime/observatory/lib/src/service/object.dart
@@ -136,6 +136,8 @@ abstract class ServiceObject extends Observable {
bool get isMirrorReference => false;
bool get isWeakProperty => false;
bool get isClosure => false;
+ bool get isStackTrace => false;
+ bool get isSimdValue => false;
bool get isPlainInstance => false;
/// Has this object been fully loaded?
@@ -2223,10 +2225,16 @@ class Instance extends HeapObject {
|| kind == 'Float32x4List'
|| kind == 'Float64x2List';
}
+ bool get isSimdValue {
+ return kind == 'Float32x4'
+ || kind == 'Float64x2'
+ || kind == 'Int32x4';
+ }
bool get isRegExp => kind == 'RegExp';
bool get isMirrorReference => kind == 'MirrorReference';
bool get isWeakProperty => kind == 'WeakProperty';
bool get isClosure => kind == 'Closure';
+ bool get isStackTrace => kind == 'StackTrace';
// TODO(turnidge): Is this properly backwards compatible when new
// instance kinds are added?
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.html ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698