Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Side by Side Diff: runtime/observatory/lib/src/service/object.dart

Issue 1316123004: Improve display of simd vector types and stack traces in Observatory. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of service; 5 part of service;
6 6
7 /// Helper function for canceling a Future<StreamSubscription>. 7 /// Helper function for canceling a Future<StreamSubscription>.
8 Future cancelFutureSubscription( 8 Future cancelFutureSubscription(
9 Future<StreamSubscription> subscriptionFuture) async { 9 Future<StreamSubscription> subscriptionFuture) async {
10 if (subscriptionFuture != null) { 10 if (subscriptionFuture != null) {
(...skipping 118 matching lines...) Expand 10 before | Expand all | Expand 10 after
129 bool get isDouble => false; 129 bool get isDouble => false;
130 bool get isString => false; 130 bool get isString => false;
131 bool get isInt => false; 131 bool get isInt => false;
132 bool get isList => false; 132 bool get isList => false;
133 bool get isMap => false; 133 bool get isMap => false;
134 bool get isTypedData => false; 134 bool get isTypedData => false;
135 bool get isRegExp => false; 135 bool get isRegExp => false;
136 bool get isMirrorReference => false; 136 bool get isMirrorReference => false;
137 bool get isWeakProperty => false; 137 bool get isWeakProperty => false;
138 bool get isClosure => false; 138 bool get isClosure => false;
139 bool get isStackTrace => false;
140 bool get isSimdValue => false;
139 bool get isPlainInstance => false; 141 bool get isPlainInstance => false;
140 142
141 /// Has this object been fully loaded? 143 /// Has this object been fully loaded?
142 bool get loaded => _loaded; 144 bool get loaded => _loaded;
143 bool _loaded = false; 145 bool _loaded = false;
144 // TODO(turnidge): Make loaded observable and get rid of loading 146 // TODO(turnidge): Make loaded observable and get rid of loading
145 // from Isolate. 147 // from Isolate.
146 148
147 /// Is this object cacheable? That is, is it impossible for the [id] 149 /// Is this object cacheable? That is, is it impossible for the [id]
148 /// of this object to change? 150 /// of this object to change?
(...skipping 2067 matching lines...) Expand 10 before | Expand all | Expand 10 after
2216 || kind == 'Int8List' 2218 || kind == 'Int8List'
2217 || kind == 'Int16List' 2219 || kind == 'Int16List'
2218 || kind == 'Int32List' 2220 || kind == 'Int32List'
2219 || kind == 'Int64List' 2221 || kind == 'Int64List'
2220 || kind == 'Float32List' 2222 || kind == 'Float32List'
2221 || kind == 'Float64List' 2223 || kind == 'Float64List'
2222 || kind == 'Int32x4List' 2224 || kind == 'Int32x4List'
2223 || kind == 'Float32x4List' 2225 || kind == 'Float32x4List'
2224 || kind == 'Float64x2List'; 2226 || kind == 'Float64x2List';
2225 } 2227 }
2228 bool get isSimdValue {
2229 return kind == 'Float32x4'
2230 || kind == 'Float64x2'
2231 || kind == 'Int32x4';
2232 }
2226 bool get isRegExp => kind == 'RegExp'; 2233 bool get isRegExp => kind == 'RegExp';
2227 bool get isMirrorReference => kind == 'MirrorReference'; 2234 bool get isMirrorReference => kind == 'MirrorReference';
2228 bool get isWeakProperty => kind == 'WeakProperty'; 2235 bool get isWeakProperty => kind == 'WeakProperty';
2229 bool get isClosure => kind == 'Closure'; 2236 bool get isClosure => kind == 'Closure';
2237 bool get isStackTrace => kind == 'StackTrace';
2230 2238
2231 // TODO(turnidge): Is this properly backwards compatible when new 2239 // TODO(turnidge): Is this properly backwards compatible when new
2232 // instance kinds are added? 2240 // instance kinds are added?
2233 bool get isPlainInstance => kind == 'PlainInstance'; 2241 bool get isPlainInstance => kind == 'PlainInstance';
2234 2242
2235 Instance._empty(ServiceObjectOwner owner) : super._empty(owner); 2243 Instance._empty(ServiceObjectOwner owner) : super._empty(owner);
2236 2244
2237 void _update(ObservableMap map, bool mapIsRef) { 2245 void _update(ObservableMap map, bool mapIsRef) {
2238 // Extract full properties. 2246 // Extract full properties.
2239 _upgradeCollection(map, isolate); 2247 _upgradeCollection(map, isolate);
(...skipping 1570 matching lines...) Expand 10 before | Expand all | Expand 10 after
3810 var v = list[i]; 3818 var v = list[i];
3811 if ((v is ObservableMap) && _isServiceMap(v)) { 3819 if ((v is ObservableMap) && _isServiceMap(v)) {
3812 list[i] = owner.getFromMap(v); 3820 list[i] = owner.getFromMap(v);
3813 } else if (v is ObservableList) { 3821 } else if (v is ObservableList) {
3814 _upgradeObservableList(v, owner); 3822 _upgradeObservableList(v, owner);
3815 } else if (v is ObservableMap) { 3823 } else if (v is ObservableMap) {
3816 _upgradeObservableMap(v, owner); 3824 _upgradeObservableMap(v, owner);
3817 } 3825 }
3818 } 3826 }
3819 } 3827 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.html ('k') | runtime/observatory/tests/ui/inspector.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698