Make dart:developer log more user friendly

Make dart:developer log more user friendly

- Make required arguments required.
- Validate required arguments in Dart before calling native.
- timestamp is now a DateTime.
- level has a default (ALL).
- sequence number is last + 1 if not provided.

R=lrn@google.com

Committed: https://github.com/dart-lang/sdk/commit/a2757141b0e17d280d5bf51ff4b81e5cf889ccaa

[Cutch, 2015-08-03 22:14:19]

johnmccutchan@google.com changed reviewers:
+ lrn@google.com

[Lasse Reichstein Nielsen, 2015-08-04 11:24:54]

That was quick :)
LGTM

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart
File runtime/lib/developer.dart (right):

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:12: int level,
Add default value for level and name.

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:18: throw new ArgumentError("message must be an
instance of String");
throw new ArgumentError.value(message, "message", "Must be a String");

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:21: throw new ArgumentError("time must be an instance
of DateTime");
throw new ArgumentError.value(time, "time", "Must be a DateTime");

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:24: sequenceNumber = _lastSequenceNumber++;
-> ++_lastSequenceNumber 
(otherwise you will repeat the the last specified sequence number once)
Alternatively, if you want to start at 0, rename _lastSequenceNumber to
_nextSequenceNumber and store "sequenceNumber + 1" below instead)

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/developer_patch.dart (right):

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/developer_patch.dart:28: int level = 0,
'=' should be ':' ?

(And yes, it IS annoying that you can't use '=' for named parameters).

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
File sdk/lib/developer/developer.dart (right):

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer.dart:47: DateTime time,
Could/should we make time optional, and have it default to new DateTime.now() ?

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer.dart:50: String name:'',
space after ':'.

[Cutch, 2015-08-04 14:11:40]

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart
File runtime/lib/developer.dart (right):

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:12: int level,
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> Add default value for level and name.

Done.

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:18: throw new ArgumentError("message must be an
instance of String");
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> throw new ArgumentError.value(message, "message", "Must be a String");

Done.

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:21: throw new ArgumentError("time must be an instance
of DateTime");
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> throw new ArgumentError.value(time, "time", "Must be a DateTime");

Done.

https://codereview.chromium.org/1266053003/diff/1/runtime/lib/developer.dart#...
runtime/lib/developer.dart:24: sequenceNumber = _lastSequenceNumber++;
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> -> ++_lastSequenceNumber 
> (otherwise you will repeat the the last specified sequence number once)
> Alternatively, if you want to start at 0, rename _lastSequenceNumber to
> _nextSequenceNumber and store "sequenceNumber + 1" below instead)

Done.

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/_internal/js_runtim...
File sdk/lib/_internal/js_runtime/lib/developer_patch.dart (right):

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/_internal/js_runtim...
sdk/lib/_internal/js_runtime/lib/developer_patch.dart:28: int level = 0,
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> '=' should be ':' ?
> 
> (And yes, it IS annoying that you can't use '=' for named parameters).

Done.

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
File sdk/lib/developer/developer.dart (right):

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer.dart:47: DateTime time,
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> Could/should we make time optional, and have it default to new DateTime.now()
?

Done.

https://codereview.chromium.org/1266053003/diff/1/sdk/lib/developer/developer...
sdk/lib/developer/developer.dart:50: String name:'',
On 2015/08/04 11:24:54, Lasse Reichstein Nielsen wrote:
> space after ':'.

Done.

[Cutch, 2015-08-04 14:12:44]

Committed patchset #2 (id:20001) manually as
a2757141b0e17d280d5bf51ff4b81e5cf889ccaa (presubmit successful).