Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2689)

Unified Diff: runtime/lib/developer.cc

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/lib/developer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/developer.cc
diff --git a/runtime/lib/developer.cc b/runtime/lib/developer.cc
index 6b7a33d2e0df8c7b95c055fac4c3820200717766..464e89b2448327a2500cdde97b6e0a9e5c7ada8c 100644
--- a/runtime/lib/developer.cc
+++ b/runtime/lib/developer.cc
@@ -39,11 +39,11 @@ DEFINE_NATIVE_ENTRY(Developer_inspect, 1) {
DEFINE_NATIVE_ENTRY(Developer_log, 8) {
- GET_NON_NULL_NATIVE_ARGUMENT(Integer, sequence, arguments->NativeArgAt(0));
+ GET_NON_NULL_NATIVE_ARGUMENT(String, message, arguments->NativeArgAt(0));
GET_NON_NULL_NATIVE_ARGUMENT(Integer, timestamp, arguments->NativeArgAt(1));
- GET_NON_NULL_NATIVE_ARGUMENT(Smi, level, arguments->NativeArgAt(2));
- GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(3));
- GET_NON_NULL_NATIVE_ARGUMENT(String, message, arguments->NativeArgAt(4));
+ GET_NON_NULL_NATIVE_ARGUMENT(Integer, sequence, arguments->NativeArgAt(2));
+ GET_NON_NULL_NATIVE_ARGUMENT(Smi, level, arguments->NativeArgAt(3));
+ GET_NON_NULL_NATIVE_ARGUMENT(String, name, arguments->NativeArgAt(4));
GET_NATIVE_ARGUMENT(Instance, dart_zone, arguments->NativeArgAt(5));
GET_NATIVE_ARGUMENT(Instance, error, arguments->NativeArgAt(6));
GET_NATIVE_ARGUMENT(Instance, stack_trace, arguments->NativeArgAt(7));
« no previous file with comments | « no previous file | runtime/lib/developer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698