Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1355)

Unified Diff: runtime/observatory/tests/service/logging_test.dart

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/developer.dart ('k') | runtime/observatory/tests/ui/log.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/tests/service/logging_test.dart
diff --git a/runtime/observatory/tests/service/logging_test.dart b/runtime/observatory/tests/service/logging_test.dart
index 62b4857fdb7a4fe36db03fa75719379ed96f59ca..cefa67bc1ab142952571765c7e2f471d020c2cc3 100644
--- a/runtime/observatory/tests/service/logging_test.dart
+++ b/runtime/observatory/tests/service/logging_test.dart
@@ -1,7 +1,6 @@
// Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-// VMOptions=--compile_all --error_on_bad_type --error_on_bad_override
import 'dart:developer' as developer;
import 'package:observatory/service_io.dart';
@@ -14,11 +13,11 @@ void init() {
Logger.root.level = Level.ALL;
Logger.root.onRecord.listen((logRecord) {
developer.log(
+ logRecord.message,
+ time: logRecord.time,
sequenceNumber: logRecord.sequenceNumber,
- millisecondsSinceEpoch: logRecord.time.millisecondsSinceEpoch,
level: logRecord.level.value,
name: logRecord.loggerName,
- message: logRecord.message,
zone: null,
error: logRecord.error,
stackTrace: logRecord.stackTrace);
« no previous file with comments | « runtime/lib/developer.dart ('k') | runtime/observatory/tests/ui/log.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698