Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: runtime/lib/developer.dart

Issue 1266053003: Make dart:developer log more user friendly (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 patch bool debugger({bool when: true, String msg}) native "Developer_debugger"; 5 patch bool debugger({bool when: true, String msg}) native "Developer_debugger";
6 6
7 patch inspect(object) native "Developer_inspect"; 7 patch inspect(object) native "Developer_inspect";
8 8
9 patch log({int sequenceNumber, 9 patch log(String message,
10 int millisecondsSinceEpoch, 10 DateTime time,
11 {int sequenceNumber,
11 int level, 12 int level,
Lasse Reichstein Nielsen 2015/08/04 11:24:54 Add default value for level and name.
Cutch 2015/08/04 14:11:40 Done.
12 String name, 13 String name,
13 String message,
14 Zone zone, 14 Zone zone,
15 Object error, 15 Object error,
16 StackTrace stackTrace}) native "Developer_log"; 16 StackTrace stackTrace}) {
17 if (message is! String) {
18 throw new ArgumentError("message must be an instance of String");
Lasse Reichstein Nielsen 2015/08/04 11:24:54 throw new ArgumentError.value(message, "message",
Cutch 2015/08/04 14:11:40 Done.
19 }
20 if (time is! DateTime) {
21 throw new ArgumentError("time must be an instance of DateTime");
Lasse Reichstein Nielsen 2015/08/04 11:24:54 throw new ArgumentError.value(time, "time", "Must
Cutch 2015/08/04 14:11:40 Done.
22 }
23 if (sequenceNumber == null) {
24 sequenceNumber = _lastSequenceNumber++;
Lasse Reichstein Nielsen 2015/08/04 11:24:54 -> ++_lastSequenceNumber (otherwise you will repe
Cutch 2015/08/04 14:11:40 Done.
25 } else {
26 _lastSequenceNumber = sequenceNumber;
27 }
28 return _log(message,
29 time.millisecondsSinceEpoch,
30 sequenceNumber,
31 level,
32 name,
33 zone,
34 error,
35 stackTrace);
36 }
37
38 int _lastSequenceNumber = 0;
39
40 _log(String message,
41 DateTime time,
42 int sequenceNumber,
43 int level,
44 String name,
45 Zone zone,
46 Object error,
47 StackTrace stackTrace) native "Developer_log";
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698