Issue 12646007: Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12646007: Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not… (Closed)

Created:
7 years, 9 months ago by Mads Ager (google)

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not destruct the eventhandler so we leaked the file descriptors for it. Also fix leak of monitor wait data objects on Windows. R=sgjesse@google.com BUG=dartbug.com/9021 Committed: https://code.google.com/p/dart/source/detail?r=19921

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+69 lines, -43 lines)			Patch
M	pkg/pkg.status	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/bin/eventhandler.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_linux.cc	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	runtime/bin/eventhandler_macos.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/eventhandler_macos.cc	View	4 chunks	+12 lines, -10 lines	0 comments	Download
M	runtime/bin/eventhandler_win.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/bin/eventhandler_win.cc	View	4 chunks	+19 lines, -13 lines	0 comments	Download
M	runtime/platform/thread_win.h	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	runtime/platform/thread_win.cc	View	2 chunks	+13 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

7 years, 9 months ago (2013-03-13 11:11:53 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19921 (presubmit successful).

Expand Messages | Collapse Messages