Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not…

runtime/bin/eventhandler_macos.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef BIN_EVENTHANDLER_MACOS_H_
 #define BIN_EVENTHANDLER_MACOS_H_
 
 #if !defined(BIN_EVENTHANDLER_H_)
 #error Do not include eventhandler_macos.h directly; use eventhandler.h instead.
 #endif
@@ skipping 88 matching lines @@
 
 class EventHandlerImplementation {
  public:
   EventHandlerImplementation();
   ~EventHandlerImplementation();
 
   // Gets the socket data structure for a given file
   // descriptor. Creates a new one if one is not found.
   SocketData* GetSocketData(intptr_t fd);
   void SendData(intptr_t id, Dart_Port dart_port, int64_t data);
-  void Start();
+  void Start(EventHandler* handler);
   void Shutdown();
 
  private:
   intptr_t GetTimeout();
   bool GetInterruptMessage(InterruptMessage* msg);
   void HandleEvents(struct kevent* events, int size);
   void HandleTimeout();
   static void EventHandlerEntry(uword args);
   void WakeupHandler(intptr_t id, Dart_Port dart_port, int64_t data);
   void HandleInterruptFd();
   void SetPort(intptr_t fd, Dart_Port dart_port, intptr_t mask);
   intptr_t GetEvents(struct kevent* event, SocketData* sd);
   static void* GetHashmapKeyFromFd(intptr_t fd);
   static uint32_t GetHashmapHashFromFd(intptr_t fd);
 
   HashMap socket_map_;
   int64_t timeout_;  // Time for next timeout.
   Dart_Port timeout_port_;
   bool shutdown_;
   int interrupt_fds_[2];
   int kqueue_fd_;
 };
 
 
 #endif  // BIN_EVENTHANDLER_MACOS_H_