Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not…

runtime/platform/thread_win.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 #if defined(TARGET_OS_WINDOWS)
 
 #include "platform/thread.h"
 
 #include <process.h>  // NOLINT
@@ skipping 24 matching lines @@
 static unsigned int __stdcall ThreadEntry(void* data_ptr) {
   ThreadStartData* data =  reinterpret_cast<ThreadStartData*>(data_ptr);
 
   Thread::ThreadStartFunction function = data->function();
   uword parameter = data->parameter();
   delete data;
 
   // Call the supplied thread start function handing it its parameters.
   function(parameter);
 
-  // When the function returns here close the handle.
-  CloseHandle(GetCurrentThread());
+  // Clean up the monitor wait data for this thread.
+  MonitorWaitData::ThreadExit();
 
   return 0;
 }
 
 
 int Thread::Start(ThreadStartFunction function, uword parameter) {
   ThreadStartData* start_data = new ThreadStartData(function, parameter);
   uint32_t tid;
   uintptr_t thread = _beginthreadex(NULL, Thread::GetMaxStackSize(),
                                     ThreadEntry, start_data, 0, &tid);
@@ skipping 109 matching lines @@
 void Monitor::Enter() {
   EnterCriticalSection(&data_.cs_);
 }
 
 
 void Monitor::Exit() {
   LeaveCriticalSection(&data_.cs_);
 }
 
 
+void MonitorWaitData::ThreadExit() {
+  uword raw_wait_data =
+    Thread::GetThreadLocal(MonitorWaitData::monitor_wait_data_key_);
+  if (raw_wait_data != 0) {
+    MonitorWaitData* wait_data =
+        reinterpret_cast<MonitorWaitData*>(raw_wait_data);
+    delete wait_data;
+  }
+}
+
+
 void MonitorData::AddWaiter(MonitorWaitData* wait_data) {
   // Add the MonitorWaitData object to the list of objects waiting for
   // this monitor.
   EnterCriticalSection(&waiters_cs_);
   if (waiters_tail_ == NULL) {
     ASSERT(waiters_head_ == NULL);
     waiters_head_ = waiters_tail_ = wait_data;
   } else {
     waiters_tail_->next_ = wait_data;
     waiters_tail_ = wait_data;
@@ skipping 148 matching lines @@
   // timeout before we signal it, that object will get an extra
   // signal. This will be treated as a spurious wake-up and is OK
   // since all uses of monitors should recheck the condition after a
   // Wait.
   data_.SignalAndRemoveAllWaiters();
 }
 
 }  // namespace dart
 
 #endif  // defined(TARGET_OS_WINDOWS)