runtime/bin/eventhandler_win.h - Issue 12646007: Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/eventhandler_win.h

Issue 12646007: Fix file descriptor leak in event handler implementation. When shutting down an isolate, we did not… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/eventhandler_win.h

diff --git a/runtime/bin/eventhandler_win.h b/runtime/bin/eventhandler_win.h

index 44d710cf7088c1af71aff3498d4ed874fe62df84..09044e0fca7a0a99b0e2fc35d928b02953238026 100644

--- a/runtime/bin/eventhandler_win.h

+++ b/runtime/bin/eventhandler_win.h

@@ -360,10 +360,10 @@ class ClientSocket : public SocketHandle {

class EventHandlerImplementation {

public:

EventHandlerImplementation();

- virtual ~EventHandlerImplementation() {}

+ virtual ~EventHandlerImplementation();

void SendData(intptr_t id, Dart_Port dart_port, int64_t data);

- void Start();

+ void Start(EventHandler* handler);

void Shutdown();

static void EventHandlerEntry(uword args);

« no previous file with comments | « runtime/bin/eventhandler_macos.cc ('k') | runtime/bin/eventhandler_win.cc » ('j') | no next file with comments »