VM: Fix more places with isolate embedded into unoptimized code.

VM: Fix more places with isolate embedded into unoptimized code.

Sharing unoptimized code between isolates requires removing all isolate-specific
immediates embedded into code and loading the isolate from the Thread object.

BUG=
R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/11733fb5b62f447befdc6956e511c22015d1f395

[Florian Schneider, 2015-07-22 11:50:11]

fschneider@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com

[Cutch, 2015-07-22 17:05:34]

https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
File runtime/vm/intermediate_language_arm.cc (right):

https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
runtime/vm/intermediate_language_arm.cc:2923: __ LoadImmediate(IP,
Isolate::Current()->stack_limit_address());
We should introduce a new function:

uword AssemblerEmbeddedPointer(void* p) {
  return reinterpret_cast<uword>(p);
}

So this would become:

__ LoadImmediate(IP,
AssemblerEmbeddedPointer(Isolate::Current()->stack_limit_address()));

Later on we can put some checks inside AssemblerEmbeddedPointer to make sure
that we aren't violating any assumptions. WDYT?

[rmacnak, 2015-07-22 17:56:52]

LGTM

On 2015/07/22 17:05:34, Cutch wrote:
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> File runtime/vm/intermediate_language_arm.cc (right):
> 
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> runtime/vm/intermediate_language_arm.cc:2923: __ LoadImmediate(IP,
> Isolate::Current()->stack_limit_address());
> We should introduce a new function:
> 
> uword AssemblerEmbeddedPointer(void* p) {
>   return reinterpret_cast<uword>(p);
> }
> 
> So this would become:
> 
> __ LoadImmediate(IP,
> AssemblerEmbeddedPointer(Isolate::Current()->stack_limit_address()));
> 
> Later on we can put some checks inside AssemblerEmbeddedPointer to make sure
> that we aren't violating any assumptions. WDYT?

We embed some pointers that aren't isolate-specific, e.g.
Symbols::PredefinedAddress. Maybe

uword IsolateSpecificPointer(void* p) {
  ASSERT(is_optimizing());
  return reinterpret_cast<uword>(p);
} ?

[Florian Schneider, 2015-07-23 09:52:32]

On 2015/07/22 17:05:34, Cutch wrote:
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> File runtime/vm/intermediate_language_arm.cc (right):
> 
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> runtime/vm/intermediate_language_arm.cc:2923: __ LoadImmediate(IP,
> Isolate::Current()->stack_limit_address());
> We should introduce a new function:
> 
> uword AssemblerEmbeddedPointer(void* p) {
>   return reinterpret_cast<uword>(p);
> }
> 
> So this would become:
> 
> __ LoadImmediate(IP,
> AssemblerEmbeddedPointer(Isolate::Current()->stack_limit_address()));
> 
> Later on we can put some checks inside AssemblerEmbeddedPointer to make sure
> that we aren't violating any assumptions. WDYT?

Yes, that would be an option. But we still need to find all places where we do
Immediate(reinterpret_cast<...> first.

[Florian Schneider, 2015-07-23 09:54:25]

On 2015/07/22 17:56:52, rmacnak wrote:
> LGTM
> 
> On 2015/07/22 17:05:34, Cutch wrote:
> >
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> > File runtime/vm/intermediate_language_arm.cc (right):
> > 
> >
>
https://codereview.chromium.org/1248113003/diff/20001/runtime/vm/intermediate...
> > runtime/vm/intermediate_language_arm.cc:2923: __ LoadImmediate(IP,
> > Isolate::Current()->stack_limit_address());
> > We should introduce a new function:
> > 
> > uword AssemblerEmbeddedPointer(void* p) {
> >   return reinterpret_cast<uword>(p);
> > }
> > 
> > So this would become:
> > 
> > __ LoadImmediate(IP,
> > AssemblerEmbeddedPointer(Isolate::Current()->stack_limit_address()));
> > 
> > Later on we can put some checks inside AssemblerEmbeddedPointer to make sure
> > that we aren't violating any assumptions. WDYT?
> 
> We embed some pointers that aren't isolate-specific, e.g.
> Symbols::PredefinedAddress. Maybe
> 
> uword IsolateSpecificPointer(void* p) {
>   ASSERT(is_optimizing());
>   return reinterpret_cast<uword>(p);
> } ?

Right, some constants are global (like PredefinedAddress) For those we need
relocation support for precompiled code (i.e. we still can't inline them into
code, but need to load them via the object pool)

[Florian Schneider, 2015-07-23 10:35:01]

Committed patchset #2 (id:20001) manually as
11733fb5b62f447befdc6956e511c22015d1f395 (presubmit successful).