Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: runtime/vm/intrinsifier_arm64.cc

Issue 1248113003: VM: Fix more places with isolate embedded into unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: minor cleanup in stub_code* Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_ARM64.
6 #if defined(TARGET_ARCH_ARM64) 6 #if defined(TARGET_ARCH_ARM64)
7 7
8 #include "vm/intrinsifier.h" 8 #include "vm/intrinsifier.h"
9 9
10 #include "vm/assembler.h" 10 #include "vm/assembler.h"
(...skipping 2088 matching lines...) Expand 10 before | Expand all | Expand 10 after
2099 // Tail-call the function. 2099 // Tail-call the function.
2100 __ ldr(R1, FieldAddress(R0, Function::instructions_offset())); 2100 __ ldr(R1, FieldAddress(R0, Function::instructions_offset()));
2101 __ AddImmediate(R1, R1, Instructions::HeaderSize() - kHeapObjectTag, kNoPP); 2101 __ AddImmediate(R1, R1, Instructions::HeaderSize() - kHeapObjectTag, kNoPP);
2102 __ br(R1); 2102 __ br(R1);
2103 } 2103 }
2104 2104
2105 2105
2106 // On stack: user tag (+0). 2106 // On stack: user tag (+0).
2107 void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) { 2107 void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
2108 // R1: Isolate. 2108 // R1: Isolate.
2109 Isolate* isolate = Isolate::Current(); 2109 __ LoadIsolate(R1);
2110 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate), kNoPP);
2111 // R0: Current user tag. 2110 // R0: Current user tag.
2112 __ ldr(R0, Address(R1, Isolate::current_tag_offset())); 2111 __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
2113 // R2: UserTag. 2112 // R2: UserTag.
2114 __ ldr(R2, Address(SP, + 0 * kWordSize)); 2113 __ ldr(R2, Address(SP, + 0 * kWordSize));
2115 // Set Isolate::current_tag_. 2114 // Set Isolate::current_tag_.
2116 __ str(R2, Address(R1, Isolate::current_tag_offset())); 2115 __ str(R2, Address(R1, Isolate::current_tag_offset()));
2117 // R2: UserTag's tag. 2116 // R2: UserTag's tag.
2118 __ ldr(R2, FieldAddress(R2, UserTag::tag_offset())); 2117 __ ldr(R2, FieldAddress(R2, UserTag::tag_offset()));
2119 // Set Isolate::user_tag_. 2118 // Set Isolate::user_tag_.
2120 __ str(R2, Address(R1, Isolate::user_tag_offset())); 2119 __ str(R2, Address(R1, Isolate::user_tag_offset()));
2121 __ ret(); 2120 __ ret();
2122 } 2121 }
2123 2122
2124 2123
2125 void Intrinsifier::UserTag_defaultTag(Assembler* assembler) { 2124 void Intrinsifier::UserTag_defaultTag(Assembler* assembler) {
2126 Isolate* isolate = Isolate::Current(); 2125 __ LoadIsolate(R0);
2127 // Set return value to default tag address. 2126 __ ldr(R0, Address(R0, Isolate::default_tag_offset()));
2128 __ LoadImmediate(R0,
2129 reinterpret_cast<uword>(isolate) + Isolate::default_tag_offset(),
2130 kNoPP);
2131 __ ldr(R0, Address(R0));
2132 __ ret(); 2127 __ ret();
2133 } 2128 }
2134 2129
2135 2130
2136 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) { 2131 void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
2137 // R1: Default tag address. 2132 __ LoadIsolate(R0);
2138 Isolate* isolate = Isolate::Current(); 2133 __ ldr(R0, Address(R0, Isolate::current_tag_offset()));
2139 __ LoadImmediate(R1, reinterpret_cast<uword>(isolate), kNoPP);
2140 // Set return value to Isolate::current_tag_.
2141 __ ldr(R0, Address(R1, Isolate::current_tag_offset()));
2142 __ ret(); 2134 __ ret();
2143 } 2135 }
2144 2136
2145 } // namespace dart 2137 } // namespace dart
2146 2138
2147 #endif // defined TARGET_ARCH_ARM64 2139 #endif // defined TARGET_ARCH_ARM64
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698