Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: runtime/vm/stub_code_arm.cc

Issue 1248113003: VM: Fix more places with isolate embedded into unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: minor cleanup in stub_code* Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_ARM) 6 #if defined(TARGET_ARCH_ARM)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/code_generator.h" 9 #include "vm/code_generator.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 1945 matching lines...) Expand 10 before | Expand all | Expand 10 after
1956 RawBigint* left, 1956 RawBigint* left,
1957 RawBigint* right); 1957 RawBigint* right);
1958 1958
1959 1959
1960 // Does identical check (object references are equal or not equal) with special 1960 // Does identical check (object references are equal or not equal) with special
1961 // checks for boxed numbers. 1961 // checks for boxed numbers.
1962 // LR: return address. 1962 // LR: return address.
1963 // Return Zero condition flag set if equal. 1963 // Return Zero condition flag set if equal.
1964 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint 1964 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint
1965 // cannot contain a value that fits in Mint or Smi. 1965 // cannot contain a value that fits in Mint or Smi.
1966 void StubCode::GenerateIdenticalWithNumberCheckStub(Assembler* assembler, 1966 static void GenerateIdenticalWithNumberCheckStub(Assembler* assembler,
1967 const Register left, 1967 const Register left,
1968 const Register right, 1968 const Register right,
1969 const Register temp, 1969 const Register temp) {
1970 const Register unused) {
1971 Label reference_compare, done, check_mint, check_bigint; 1970 Label reference_compare, done, check_mint, check_bigint;
1972 // If any of the arguments is Smi do reference compare. 1971 // If any of the arguments is Smi do reference compare.
1973 __ tst(left, Operand(kSmiTagMask)); 1972 __ tst(left, Operand(kSmiTagMask));
1974 __ b(&reference_compare, EQ); 1973 __ b(&reference_compare, EQ);
1975 __ tst(right, Operand(kSmiTagMask)); 1974 __ tst(right, Operand(kSmiTagMask));
1976 __ b(&reference_compare, EQ); 1975 __ b(&reference_compare, EQ);
1977 1976
1978 // Value compare for two doubles. 1977 // Value compare for two doubles.
1979 __ CompareClassId(left, kDoubleCid, temp); 1978 __ CompareClassId(left, kDoubleCid, temp);
1980 __ b(&check_mint, NE); 1979 __ b(&check_mint, NE);
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
2126 // Result: 2125 // Result:
2127 // R1: entry point. 2126 // R1: entry point.
2128 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) { 2127 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) {
2129 EmitMegamorphicLookup(assembler, R0, R1, R1); 2128 EmitMegamorphicLookup(assembler, R0, R1, R1);
2130 __ Ret(); 2129 __ Ret();
2131 } 2130 }
2132 2131
2133 } // namespace dart 2132 } // namespace dart
2134 2133
2135 #endif // defined TARGET_ARCH_ARM 2134 #endif // defined TARGET_ARCH_ARM
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698