Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(834)

Unified Diff: runtime/vm/stub_code_arm64.cc

Issue 1248113003: VM: Fix more places with isolate embedded into unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: minor cleanup in stub_code* Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/stub_code_arm64.cc
diff --git a/runtime/vm/stub_code_arm64.cc b/runtime/vm/stub_code_arm64.cc
index 007bfe91f444bb000695d47f8f9afc7794a1a98c..93995dfd5d118aaad3d07ff451b2a9f2854712d6 100644
--- a/runtime/vm/stub_code_arm64.cc
+++ b/runtime/vm/stub_code_arm64.cc
@@ -2035,11 +2035,9 @@ DECLARE_LEAF_RUNTIME_ENTRY(intptr_t,
// Return Zero condition flag set if equal.
// Note: A Mint cannot contain a value that would fit in Smi, a Bigint
// cannot contain a value that fits in Mint or Smi.
-void StubCode::GenerateIdenticalWithNumberCheckStub(Assembler* assembler,
- const Register left,
- const Register right,
- const Register unused1,
- const Register unused2) {
+static void GenerateIdenticalWithNumberCheckStub(Assembler* assembler,
+ const Register left,
+ const Register right) {
Label reference_compare, done, check_mint, check_bigint;
// If any of the arguments is Smi do reference compare.
__ tsti(left, Immediate(kSmiTagMask));
@@ -2131,12 +2129,11 @@ void StubCode::GenerateUnoptimizedIdenticalWithNumberCheckStub(
// Return Zero condition flag set if equal.
void StubCode::GenerateOptimizedIdenticalWithNumberCheckStub(
Assembler* assembler) {
- const Register temp = R2;
const Register left = R1;
const Register right = R0;
__ LoadFromOffset(left, SP, 1 * kWordSize, kNoPP);
__ LoadFromOffset(right, SP, 0 * kWordSize, kNoPP);
- GenerateIdenticalWithNumberCheckStub(assembler, left, right, temp);
+ GenerateIdenticalWithNumberCheckStub(assembler, left, right);
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698