Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 1247803002: Refactor dart:developer log to use named parameters (Closed)

Created:
5 years, 5 months ago by Cutch
Modified:
5 years, 5 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Refactor dart:developer log to use named parameters BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/bfd2d4ed2a40d8aff7926d1f9ff058643c83a21b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -35 lines) Patch
M runtime/lib/developer.dart View 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/logging_test.dart View 1 chunk +11 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/developer_patch.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M sdk/lib/developer/developer.dart View 1 chunk +7 lines, -19 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 5 months ago (2015-07-21 16:06:37 UTC) #2
rmacnak
lgtm
5 years, 5 months ago (2015-07-21 16:55:37 UTC) #3
Cutch
5 years, 5 months ago (2015-07-21 17:01:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bfd2d4ed2a40d8aff7926d1f9ff058643c83a21b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698