Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Issue 12295009: Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. (Closed)

Created:
7 years, 10 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 10 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. This reverts r18591. Committed: https://code.google.com/p/dart/source/detail?r=18615

Patch Set 1 #

Patch Set 2 : More tests. Fix Future.wait to not run iterator more than once. Fix pub to not have side-effects in… #

Patch Set 3 : Make Future.wait simpler. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+505 lines, -1118 lines) Patch
M editor/util/plugins/com.google.dart.java2dart/resources/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer-experimental/lib/src/generated/java_core.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/http/lib/src/byte_stream.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/serialization/lib/src/format.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/array.dart View 4 chunks +2 lines, -10 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/lib/growable_array.dart View 2 chunks +1 line, -5 lines 0 comments Download
M samples/swarm/swarm_ui_lib/observable/observable.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/_collection_dev/iterable.dart View 1 9 chunks +29 lines, -338 lines 0 comments Download
M sdk/lib/_collection_dev/list.dart View 2 chunks +15 lines, -261 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_array.dart View 2 chunks +1 line, -5 lines 0 comments Download
M sdk/lib/async/future_impl.dart View 1 2 1 chunk +20 lines, -17 lines 1 comment Download
M sdk/lib/async/stream.dart View 1 chunk +0 lines, -7 lines 0 comments Download
M sdk/lib/collection/collections.dart View 5 chunks +5 lines, -15 lines 0 comments Download
M sdk/lib/core/iterable.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M sdk/lib/core/list.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 73 chunks +36 lines, -149 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 73 chunks +36 lines, -149 lines 0 comments Download
M sdk/lib/html/html_common/filtered_element_list.dart View 2 chunks +1 line, -2 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 12 chunks +6 lines, -24 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 12 chunks +6 lines, -24 lines 0 comments Download
M tests/corelib/iterable_skip_test.dart View 1 8 chunks +50 lines, -21 lines 0 comments Download
M tests/corelib/iterable_take_test.dart View 8 chunks +0 lines, -22 lines 0 comments Download
A tests/corelib/list_map_test.dart View 1 1 chunk +164 lines, -0 lines 0 comments Download
M tests/corelib/list_reversed_test.dart View 1 2 chunks +111 lines, -15 lines 0 comments Download
M tests/html/element_classes_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/element_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/streams_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/async/stream_controller_async_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/src/CssClassSet.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 4 chunks +2 lines, -10 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Node.darttemplate View 2 chunks +1 line, -5 lines 0 comments Download
M tools/dom/templates/immutable_list_mixin.darttemplate View 2 chunks +1 line, -4 lines 0 comments Download
M utils/pub/entrypoint.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M utils/pub/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/template/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
7 years, 10 months ago (2013-02-18 09:25:36 UTC) #1
Lasse Reichstein Nielsen
https://codereview.chromium.org/12295009/diff/5004/sdk/lib/async/future_impl.dart File sdk/lib/async/future_impl.dart (right): https://codereview.chromium.org/12295009/diff/5004/sdk/lib/async/future_impl.dart#newcode114 sdk/lib/async/future_impl.dart:114: factory _FutureImpl.wait(Iterable<Future> futures) { This implementation of wait is ...
7 years, 10 months ago (2013-02-18 09:59:29 UTC) #2
floitsch
7 years, 10 months ago (2013-02-18 10:34:09 UTC) #3
LGTM.

Powered by Google App Engine
This is Rietveld 408576698