Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1472)

Unified Diff: utils/pub/entrypoint.dart

Issue 12295009: Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make Future.wait simpler. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/entrypoint.dart
diff --git a/utils/pub/entrypoint.dart b/utils/pub/entrypoint.dart
index 054541d4e303a0967a33e5b88bbb17d38b128cf2..7de7c2c19f56eed050699e0d9b210fc2a9ef559b 100644
--- a/utils/pub/entrypoint.dart
+++ b/utils/pub/entrypoint.dart
@@ -134,7 +134,7 @@ class Entrypoint {
return Future.wait(packageVersions.map((id) {
if (id.isRoot) return new Future.immediate(id);
return install(id);
- }));
+ }).toList());
}).then(_saveLockFile)
.then(_installSelfReference)
.then(_linkSecondaryPackageDirs);
@@ -267,7 +267,7 @@ class Entrypoint {
if (!dirExists(file)) return;
return _linkSecondaryPackageDir(file);
});
- }));
+ }).toList());
});
});
}
@@ -287,7 +287,7 @@ class Entrypoint {
fileAndSubfiles.addAll(subfiles);
return fileAndSubfiles;
});
- }));
+ }).toList());
}).then(flatten);
}

Powered by Google App Engine
This is Rietveld 408576698