Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Unified Diff: sdk/lib/collection/collections.dart

Issue 12295009: Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make Future.wait simpler. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/collection/collections.dart
diff --git a/sdk/lib/collection/collections.dart b/sdk/lib/collection/collections.dart
index 7608c02c3f20b1099360d15b8bcce8672bdaeae5..fc27c9158e9ff44236737fdcf145722a37a1ad4d 100644
--- a/sdk/lib/collection/collections.dart
+++ b/sdk/lib/collection/collections.dart
@@ -318,12 +318,7 @@ class IterableMixinWorkaround {
}
static Iterable mapList(List list, f(var element)) {
- return new MappedListIterable(list, f, 0, null);
- }
-
- static List mappedByList(List list, f(var element)) {
- // This is currently a List as well as an Iterable.
- return new MappedList(list, f);
+ return new MappedListIterable(list, f);
}
static Iterable expand(Iterable iterable, Iterable f(var element)) {
@@ -333,7 +328,7 @@ class IterableMixinWorkaround {
static Iterable takeList(List list, int n) {
// The generic type is currently lost. It will be fixed with mixins.
// This is currently a List as well as an Iterable.
- return new ListView(list, 0, n);
+ return new SubListIterable(list, 0, n);
}
static Iterable takeWhile(Iterable iterable, bool test(var value)) {
@@ -344,7 +339,7 @@ class IterableMixinWorkaround {
static Iterable skipList(List list, int n) {
// The generic type is currently lost. It will be fixed with mixins.
// This is currently a List as well as an Iterable.
- return new ListView(list, n, null);
+ return new SubListIterable(list, n, null);
}
static Iterable skipWhile(Iterable iterable, bool test(var value)) {
@@ -352,8 +347,8 @@ class IterableMixinWorkaround {
return new SkipWhileIterable(iterable, test);
}
- static List reversedList(List l) {
- return new ReversedListView(l, 0, null);
+ static Iterable reversedList(List l) {
+ return new ReversedListIterable(l);
}
static void sortList(List l, int compare(a, b)) {
@@ -474,11 +469,6 @@ class Collections {
/** Deprecated. Use the same method in [IterableMixinWorkaround] instead.*/
@deprecated
- static List mappedByList(List list, f(var element))
- => IterableMixinWorkaround.mappedByList(list, f);
-
- /** Deprecated. Use the same method in [IterableMixinWorkaround] instead.*/
- @deprecated
static Iterable takeList(List list, int n)
=> IterableMixinWorkaround.takeList(list, n);

Powered by Google App Engine
This is Rietveld 408576698