Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: runtime/lib/array.dart

Issue 12295009: Recommit changing List.skip/take/revert returns Iterable and remove mappedBy. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Make Future.wait simpler. Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/lib/array.dart
diff --git a/runtime/lib/array.dart b/runtime/lib/array.dart
index 3ce453bba5e3625287e521949cf1ca9908b2a019..1441dc2a50e4b34a97de693994693f7f365f85ea 100644
--- a/runtime/lib/array.dart
+++ b/runtime/lib/array.dart
@@ -104,10 +104,6 @@ class _ObjectArray<E> implements List<E> {
return IterableMixinWorkaround.mapList(this, f);
}
- List mappedBy(f(E element)) {
- IterableMixinWorkaround.mappedByList(this, f);
- }
-
reduce(initialValue, combine(previousValue, E element)) {
return IterableMixinWorkaround.reduce(this, initialValue, combine);
}
@@ -164,7 +160,7 @@ class _ObjectArray<E> implements List<E> {
return this.length == 0;
}
- List<E> get reversed => new ReversedListView<E>(this, 0, null);
+ Iterable<E> get reversed => new ReversedListIterable<E>(this);
void sort([int compare(E a, E b)]) {
IterableMixinWorkaround.sortList(this, compare);
@@ -338,10 +334,6 @@ class _ImmutableArray<E> implements List<E> {
return IterableMixinWorkaround.mapList(this, f);
}
- List mappedBy(f(E element)) {
- return IterableMixinWorkaround.mappedByList(this, f);
- }
-
String join([String separator]) {
return IterableMixinWorkaround.joinList(this, separator);
}
@@ -402,7 +394,7 @@ class _ImmutableArray<E> implements List<E> {
return this.length == 0;
}
- List<E> get reversed => new ReversedListView<E>(this, 0, null);
+ Iterable<E> get reversed => new ReversedListIterable<E>(this);
void sort([int compare(E a, E b)]) {
throw new UnsupportedError(

Powered by Google App Engine
This is Rietveld 408576698