Add a Pub validator for READMEs that are invalid utf-8.

Add a Pub validator for READMEs that are invalid utf-8.

BUG=7045
Committed: https://code.google.com/p/dart/source/detail?r=17948

[Bob Nystrom, 2013-01-31 19:08:29]

https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart#...
utils/pub/entrypoint.dart:63: /// chosen.
How about moving this to Package? It's not specific to the entrypoint.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode90
utils/pub/io.dart:90: Future<List<int>> readByteFile(file) {
"Byte" -> "Binary"?

"ByteFile" reads strangely to me.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode93
utils/pub/io.dart:93: new File(path).readAsBytes(),
Feel free to make this sync if you prefer.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode123
utils/pub/io.dart:123: Future<File> writeByteFile(file, List<int> contents) {
Byte -> Binary.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode127
utils/pub/io.dart:127: log.io("Writing ${contents.length} characters to binary
file $path.");
"characters" -> "bytes".

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode134
utils/pub/io.dart:134: });
then() then() then()

Make this sync?

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
File utils/pub/validator/utf8_readme.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
utils/pub/validator/utf8_readme.dart:18: /// output.
Fix doc comment.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
utils/pub/validator/utf8_readme.dart:30: // isn't valid utf-8.
Good God, that's a bad API.

[nweiz, 2013-01-31 21:39:10]

https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart
File utils/pub/entrypoint.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/entrypoint.dart#...
utils/pub/entrypoint.dart:63: /// chosen.
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> How about moving this to Package? It's not specific to the entrypoint.

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart
File utils/pub/io.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode90
utils/pub/io.dart:90: Future<List<int>> readByteFile(file) {
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> "Byte" -> "Binary"?
> 
> "ByteFile" reads strangely to me.

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode93
utils/pub/io.dart:93: new File(path).readAsBytes(),
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> Feel free to make this sync if you prefer.

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode123
utils/pub/io.dart:123: Future<File> writeByteFile(file, List<int> contents) {
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> Byte -> Binary.

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode127
utils/pub/io.dart:127: log.io("Writing ${contents.length} characters to binary
file $path.");
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> "characters" -> "bytes".

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/io.dart#newcode134
utils/pub/io.dart:134: });
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> then() then() then()
> 
> Make this sync?

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
File utils/pub/validator/utf8_readme.dart (right):

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
utils/pub/validator/utf8_readme.dart:18: /// output.
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> Fix doc comment.

Done.

https://codereview.chromium.org/12090081/diff/4006/utils/pub/validator/utf8_r...
utils/pub/validator/utf8_readme.dart:30: // isn't valid utf-8.
On 2013/01/31 19:08:29, Bob Nystrom wrote:
> Good God, that's a bad API.

It would be a little better if it used keyword args...

[Bob Nystrom, 2013-01-31 21:44:49]

LGTM