Issue 12049065: Fix bugs in GrowableList.remove*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12049065: Fix bugs in GrowableList.remove*. (Closed)

Created:
7 years, 11 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 11 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix bugs in GrowableList.remove*. Add generic removeMatchingList functionality in IterableMixinWorkaround. BUG=http://dartbug.com/8018, http://dartbug.com/8075 Committed: https://code.google.com/p/dart/source/detail?r=17534

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. Fix typo in filtered list. #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+188 lines, -29 lines)			Patch
M	runtime/lib/growable_array.dart	View		1 chunk	+18 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View	1	1 chunk	+5 lines, -4 lines	0 comments	Download
M	sdk/lib/collection/collections.dart	View		4 chunks	+32 lines, -1 line	0 comments	Download
M	sdk/lib/core/collection.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	sdk/lib/html/dart2js/html_dart2js.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	sdk/lib/html/html_common/filtered_element_list.dart	View	1	2 chunks	+5 lines, -5 lines	0 comments	Download
A	tests/corelib/collection_removes_test.dart	View	1	1 chunk	+109 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Element.darttemplate	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

7 years, 11 months ago (2013-01-24 09:40:36 UTC) #2

LGTM

https://codereview.chromium.org/12049065/diff/1/runtime/lib/growable_array.dart
File runtime/lib/growable_array.dart (right):

https://codereview.chromium.org/12049065/diff/1/runtime/lib/growable_array.da...
runtime/lib/growable_array.dart:27: removeAt(i);
Nice :)

https://codereview.chromium.org/12049065/diff/1/tests/corelib/collection_remo...
File tests/corelib/collection_removes_test.dart (right):

https://codereview.chromium.org/12049065/diff/1/tests/corelib/collection_remo...
tests/corelib/collection_removes_test.dart:23:
Expect.isFalse(removes.contains(value), "$value: $base - $removes / $retained");
Long line.

Expand Messages | Collapse Messages