Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(551)

Unified Diff: sdk/lib/html/html_common/filtered_element_list.dart

Issue 12049065: Fix bugs in GrowableList.remove*. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Fix typo in filtered list. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tests/corelib/collection_removes_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/html/html_common/filtered_element_list.dart
diff --git a/sdk/lib/html/html_common/filtered_element_list.dart b/sdk/lib/html/html_common/filtered_element_list.dart
index a9cce44413ab449d919d18bd28aabc83c0d60a87..287a5f8e53aae71212790faefc26a4f08bf6f835 100644
--- a/sdk/lib/html/html_common/filtered_element_list.dart
+++ b/sdk/lib/html/html_common/filtered_element_list.dart
@@ -69,7 +69,7 @@ class FilteredElementList implements List {
return element is Element && _childNodes.contains(element);
}
- List<E> get reversed => new ReversedListView<E>(_filtered, 0, null);
+ List<Element> get reversed => new ReversedListView<Element>(_filtered, 0, null);
void sort([int compare(Element a, Element b)]) {
throw new UnsupportedError('TODO(jacobr): should we impl?');
@@ -125,19 +125,19 @@ class FilteredElementList implements List {
void removeAll(Iterable elements) {
// This should be optimized to not use [remove] directly.
- Collections.removeAll(this, elements);
+ IterableMixinWorkaround.removeAll(this, elements);
}
void retainAll(Iterable elements) {
- Collections.retainAll(this, elements);
+ IterableMixinWorkaround.retainAll(this, elements);
}
void removeMatching(bool test(Element element)) {
- Collections.removeMatching(this, test);
+ IterableMixinWorkaround.removeMatching(this, test);
}
void retainMatching(bool test(Element element)) {
- Collections.retainMatching(this, test);
+ IterableMixinWorkaround.retainMatching(this, test);
}
dynamic reduce(dynamic initialValue,
« no previous file with comments | « sdk/lib/html/dartium/html_dartium.dart ('k') | tests/corelib/collection_removes_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698