Fix bugs in GrowableList.remove*.

tests/corelib/collection_removes_test.dart

Index: tests/corelib/collection_removes_test.dart
diff --git a/tests/corelib/collection_removes_test.dart b/tests/corelib/collection_removes_test.dart
new file mode 100644
index 0000000000000000000000000000000000000000..738ce72f1f4c9cf9c0b637e1815b3f372d88e910
--- /dev/null
+++ b/tests/corelib/collection_removes_test.dart
@@ -0,0 +1,109 @@
+// Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+testRemove(Collection base) {
+  int length = base.length;
+  for (int i = 0; i < length; i++) {
+    Expect.isFalse(base.isEmpty);
+    base.remove(base.first);
+  }
+  Expect.isTrue(base.isEmpty);
+}
+
+testRemoveAll(Collection base, Iterable removes) {
+  Set retained = new Set();
+  for (var element in base) {
+    if (!removes.contains(element)) {
+      retained.add(element);
+    }
+  }
+  String name = "$base.removeAll($removes) -> $retained";
+  base.removeAll(removes);
+  for (var value in base) {
+    Expect.isFalse(removes.contains(value), "$name: Found $value");
+  }
+  for (var value in retained) {
+    Expect.isTrue(base.contains(value), "$name: Found $value");
+  }
+}
+
+testRetainAll(Collection base, Iterable retains) {
+  Set retained = new Set();
+  for (var element in base) {
+    if (retains.contains(element)) {
+      retained.add(element);
+    }
+  }
+  String name = "$base.retainAll($retains) -> $retained";
+  base.retainAll(retains);
+  for (var value in base) {
+    Expect.isTrue(retains.contains(value), "$name: Found $value");
+  }
+  for (var value in retained) {
+    Expect.isTrue(base.contains(value), "$name: Found $value");
+  }
+}
+
+testRemoveMatching(Collection base, bool test(value)) {
+  Set retained = new Set();
+  for (var element in base) {
+    if (!test(element)) {
+      retained.add(element);
+    }
+  }
+  String name = "$base.removeMatching(...) -> $retained";
+  base.removeMatching(test);
+  for (var value in base) {
+    Expect.isFalse(test(value), "$name: Found $value");
+  }
+  for (var value in retained) {
+    Expect.isTrue(base.contains(value), "$name: Found $value");
+  }
+}
+
+testRetainMatching(Collection base, bool test(value)) {
+  Set retained = new Set();
+  for (var element in base) {
+    if (test(element)) {
+      retained.add(element);
+    }
+  }
+  String name = "$base.retainMatching(...) -> $retained";
+  base.retainMatching(test);
+  for (var value in base) {
+    Expect.isTrue(test(value), "$name: Found $value");
+  }
+  for (var value in retained) {
+    Expect.isTrue(base.contains(value), "$name: Found $value");
+  }
+}
+
+void main() {
+  var collections = [
+    [], [1], [2], [1, 2], [1, 2, 3, 4, 5, 6, 7, 8, 9, 10],
+    [1, 3, 5, 7, 9], [2, 4, 6, 8, 10]
+  ];
+  for (var base in collections) {
+    for (var delta in collections) {
+      testRemove(base.toList());
+      testRemove(base.toSet());
+
+      var deltaSet = delta.toSet();
+      testRemoveAll(base.toList(), delta);
+      testRemoveAll(base.toList(), deltaSet);
+      testRetainAll(base.toList(), delta);
+      testRetainAll(base.toList(), deltaSet);
+      testRemoveMatching(base.toList(), deltaSet.contains);
+      testRetainMatching(base.toList(), (e) => !deltaSet.contains(e));
+
+      testRemoveAll(base.toSet(), delta);
+      testRemoveAll(base.toSet(), deltaSet);
+      testRetainAll(base.toSet(), delta);
+      testRetainAll(base.toSet(), deltaSet);
+      testRemoveMatching(base.toSet(), deltaSet.contains);
+      testRetainMatching(base.toSet(), (e) => !deltaSet.contains(e));
+    }
+  }
+}
+