Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_array.dart

Issue 12049065: Fix bugs in GrowableList.remove*. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address comment. Fix typo in filtered list. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | sdk/lib/collection/collections.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/compiler/implementation/lib/js_array.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
index 3be692d142b4f65e84952e647e538eef88f36edd..13c72b7b3d31a0a7badd1c7f3308f832032edaa4 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_array.dart
@@ -44,20 +44,21 @@ class JSArray<E> implements List<E> {
}
void removeAll(Iterable elements) {
- Collections.removeAll(this, elements);
+ IterableMixinWorkaround.removeAllList(this, elements);
}
void retainAll(Iterable elements) {
- Collections.retainAll(this, elements);
+ IterableMixinWorkaround.retainAll(this, elements);
}
void removeMatching(bool test(E element)) {
// This could, and should, be optimized.
- Collections.removeMatching(this, test);
+ IterableMixinWorkaround.removeMatchingList(this, test);
}
void reatainMatching(bool test(E element)) {
- Collections.reatainMatching(this, test);
+ IterableMixinWorkaround.removeMatchingList(this,
+ (E element) => !test(element));
}
Iterable<E> where(bool f(E element)) {
« no previous file with comments | « runtime/lib/growable_array.dart ('k') | sdk/lib/collection/collections.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698