Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Issue 1183723002: Explicitly compute library errors in tests. (Closed)

Created:
5 years, 6 months ago by scheglov
Modified:
5 years, 6 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1299 lines, -1299 lines) Patch
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest_test.dart View 12 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 10 chunks +9 lines, -18 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 402 chunks +420 lines, -420 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 404 chunks +425 lines, -416 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 162 chunks +168 lines, -168 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 238 chunks +254 lines, -254 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 6 months ago (2015-06-12 18:26:46 UTC) #1
Brian Wilkerson
LGTM
5 years, 6 months ago (2015-06-12 19:21:05 UTC) #2
scheglov
5 years, 6 months ago (2015-06-12 19:28:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9634a0339355b5400600a815f3b3e31dd3e538b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698