pkg/analyzer/test/generated/incremental_resolver_test.dart - Issue 1183723002: Explicitly compute library errors in tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analyzer/test/generated/incremental_resolver_test.dart

Issue 1183723002: Explicitly compute library errors in tests. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analyzer/test/generated/compile_time_error_code_test.dart ('k') | pkg/analyzer/test/generated/non_error_resolver_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analyzer/test/generated/incremental_resolver_test.dart

diff --git a/pkg/analyzer/test/generated/incremental_resolver_test.dart b/pkg/analyzer/test/generated/incremental_resolver_test.dart

index 735a88206ad34d6af99580e5d2e256e574feac06..54bb524d2e57997f6d5ba9302997cb6451814fdd 100644

--- a/pkg/analyzer/test/generated/incremental_resolver_test.dart

+++ b/pkg/analyzer/test/generated/incremental_resolver_test.dart

@@ -2447,7 +2447,7 @@ class B extends Object with A {}

void _assertMatchKind(

DeclarationMatchKind expectMatch, String oldContent, String newContent) {

Source source = addSource(oldContent);

- LibraryElement library = resolve(source);

+ LibraryElement library = resolve2(source);

CompilationUnit oldUnit = resolveCompilationUnit(source, library);

// parse

CompilationUnit newUnit = ParserTestCase.parseCompilationUnit(newContent);

@@ -2824,7 +2824,7 @@ class B {

{

source = addSource(newCode);

_runTasks();

- LibraryElement library = resolve(source);

+ LibraryElement library = resolve2(source);

fullNewUnit = resolveCompilationUnit(source, library);

}

try {

@@ -2843,7 +2843,7 @@ class B {

void _resolveUnit(String code) {

this.code = code;

source = addSource(code);

- library = resolve(source);

+ library = resolve2(source);

unit = resolveCompilationUnit(source, library);

_runTasks();

}

@@ -3868,7 +3868,7 @@ f3() {

void _resolveUnit(String code) {

this.code = code;

source = addSource(code);

- oldLibrary = resolve(source);

+ oldLibrary = resolve2(source);

oldUnit = resolveCompilationUnit(source, oldLibrary);

oldUnitElement = oldUnit.element;

}

@@ -3908,7 +3908,7 @@ f3() {

source = addSource(newCode + ' ');

source = addSource(newCode);

_runTasks();

- LibraryElement library = resolve(source);

+ LibraryElement library = resolve2(source);

CompilationUnit fullNewUnit = resolveCompilationUnit(source, library);

// Validate tokens.

_assertEqualTokens(newUnit, fullNewUnit);