Explicitly compute library errors in tests.

pkg/analyzer/test/generated/compile_time_error_code_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.compile_time_error_code_test;
 
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
 import 'package:analyzer/src/generated/parser.dart' show ParserErrorCode;
 import 'package:analyzer/src/generated/source_io.dart';
 import 'package:unittest/unittest.dart' as _ut;
 
 import '../reflective_tests.dart';
 import 'resolver_test.dart';
 
 main() {
   _ut.groupSep = ' | ';
   runReflectiveTests(CompileTimeErrorCodeTest);
 }
 
 @reflectiveTest
 class CompileTimeErrorCodeTest extends ResolverTestCase {
-  /**
-   * Computes errors for the given [librarySource].
-   * This assumes that the given [librarySource] and its parts have already
-   * been added to the content provider using the method [addNamedSource].
-   */
-  void computeLibrarySourceErrors(Source librarySource) {
-    analysisContext.computeErrors(librarySource);
-  }
-
   void fail_awaitInWrongContext_sync() {
     // This test requires better error recovery than we currently have. In
     // particular, we need to be able to distinguish between an await expression
     // in the wrong context, and the use of 'await' as an identifier.
     Source source = addSource(r'''
 f(x) {
   return await x;
 }''');
     computeLibrarySourceErrors(source);
     assertErrors(source, [CompileTimeErrorCode.AWAIT_IN_WRONG_CONTEXT]);
@@ skipping 4668 matching lines @@
     addNamedSource('/lib.dart', '''
 library lib;
 g() {}
 ''');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   p?.g();
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefix_conditionalPropertyAccess_call_loadLibrary() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 ''');
     Source source = addSource('''
 import 'lib.dart' deferred as p;
 f() {
   p?.loadLibrary();
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefix_conditionalPropertyAccess_get() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 var x;
 ''');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   return p?.x;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefix_conditionalPropertyAccess_get_loadLibrary() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 ''');
     Source source = addSource('''
 import 'lib.dart' deferred as p;
 f() {
   return p?.loadLibrary;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefix_conditionalPropertyAccess_set() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 var x;
 ''');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   p?.x = null;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefix_conditionalPropertyAccess_set_loadLibrary() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 ''');
     Source source = addSource('''
 import 'lib.dart' deferred as p;
 f() {
   p?.loadLibrary = null;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefixCollidesWithTopLevelMembers_functionTypeAlias() {
     addNamedSource("/lib.dart", r'''
 library lib;
 class A{}''');
     Source source = addSource(r'''
@@ skipping 49 matching lines @@
   }
 
   void test_prefixNotFollowedByDot() {
     addNamedSource('/lib.dart', 'library lib;');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   return p;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefixNotFollowedByDot_compoundAssignment() {
     addNamedSource('/lib.dart', 'library lib;');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   p += 1;
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_prefixNotFollowedByDot_conditionalMethodInvocation() {
     AnalysisOptionsImpl options = new AnalysisOptionsImpl();
     options.enableNullAwareOperators = true;
     resetWithOptions(options);
     addNamedSource('/lib.dart', '''
 library lib;
 g() {}
 ''');
     Source source = addSource('''
 import 'lib.dart' as p;
 f() {
   p?.g();
 }
 ''');
-    resolve(source);
+    computeLibrarySourceErrors(source);
     assertErrors(
         source, [CompileTimeErrorCode.PREFIX_IDENTIFIER_NOT_FOLLOWED_BY_DOT]);
     verify([source]);
   }
 
   void test_privateOptionalParameter() {
     Source source = addSource("f({var _p}) {}");
     computeLibrarySourceErrors(source);
     assertErrors(source, [CompileTimeErrorCode.PRIVATE_OPTIONAL_PARAMETER]);
     verify([source]);
@@ skipping 1110 matching lines @@
         source, [CompileTimeErrorCode.WRONG_NUMBER_OF_PARAMETERS_FOR_OPERATOR]);
     verify([source]);
     reset();
   }
 
   void _check_wrongNumberOfParametersForOperator1(String name) {
     _check_wrongNumberOfParametersForOperator(name, "");
     _check_wrongNumberOfParametersForOperator(name, "a, b");
   }
 }