Explicitly compute library errors in tests.

pkg/analyzer/test/generated/incremental_resolver_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver_test;
 
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/element.dart';
 import 'package:analyzer/src/generated/engine.dart';
 import 'package:analyzer/src/generated/error.dart';
@@ skipping 2429 matching lines @@
     _assertMatchKind(DeclarationMatchKind.MISMATCH_OK, oldContent, newContent);
   }
 
   void _assertMatches(String oldContent, String newContent) {
     _assertMatchKind(DeclarationMatchKind.MATCH, oldContent, newContent);
   }
 
   void _assertMatchKind(
       DeclarationMatchKind expectMatch, String oldContent, String newContent) {
     Source source = addSource(oldContent);
-    LibraryElement library = resolve(source);
+    LibraryElement library = resolve2(source);
     CompilationUnit oldUnit = resolveCompilationUnit(source, library);
     // parse
     CompilationUnit newUnit = ParserTestCase.parseCompilationUnit(newContent);
     // build elements
     {
       ElementHolder holder = new ElementHolder();
       ElementBuilder builder = new ElementBuilder(holder);
       newUnit.accept(builder);
     }
     // match
@@ skipping 356 matching lines @@
             .getReadableSourceEntryOrNull(source), null, null, unit.element,
         updateOffset, updateEndOld, updateOldNew);
     bool success = resolver.resolve(newNode);
     expect(success, isTrue);
     List<AnalysisError> newErrors = analysisContext.computeErrors(source);
     // resolve "newCode" from scratch
     CompilationUnit fullNewUnit;
     {
       source = addSource(newCode);
       _runTasks();
-      LibraryElement library = resolve(source);
+      LibraryElement library = resolve2(source);
       fullNewUnit = resolveCompilationUnit(source, library);
     }
     try {
       assertSameResolution(unit, fullNewUnit);
     } on IncrementalResolutionMismatch catch (mismatch) {
       fail(mismatch.message);
     }
     // errors
     List<AnalysisError> newFullErrors =
         analysisContext.getErrors(source).errors;
     _assertEqualErrors(newErrors, newFullErrors);
     // prepare for the next cycle
     code = newCode;
   }
 
   void _resolveUnit(String code) {
     this.code = code;
     source = addSource(code);
-    library = resolve(source);
+    library = resolve2(source);
     unit = resolveCompilationUnit(source, library);
     _runTasks();
   }
 
   void _runTasks() {
     AnalysisResult result = analysisContext.performAnalysisTask();
     while (result.changeNotices != null) {
       result = analysisContext.performAnalysisTask();
     }
   }
@@ skipping 1004 matching lines @@
     analysisOptions.incremental = enable;
     analysisOptions.incrementalApi = enable;
 //    log.logger = log.PRINT_LOGGER;
     log.logger = log.NULL_LOGGER;
     analysisContext2.analysisOptions = analysisOptions;
   }
 
   void _resolveUnit(String code) {
     this.code = code;
     source = addSource(code);
-    oldLibrary = resolve(source);
+    oldLibrary = resolve2(source);
     oldUnit = resolveCompilationUnit(source, oldLibrary);
     oldUnitElement = oldUnit.element;
   }
 
   void _runTasks() {
     AnalysisResult result = analysisContext.performAnalysisTask();
     while (result.changeNotices != null) {
       result = analysisContext.performAnalysisTask();
     }
   }
@@ skipping 19 matching lines @@
     // "newUnit", so all clients will get it using the usual way.
     AnalysisResult analysisResult = analysisContext.performAnalysisTask();
     ChangeNotice notice = analysisResult.changeNotices[0];
     expect(notice.resolvedDartUnit, same(newUnit));
     // Resolve "newCode" from scratch.
     if (compareWithFull) {
       _resetWithIncremental(false);
       source = addSource(newCode + ' ');
       source = addSource(newCode);
       _runTasks();
-      LibraryElement library = resolve(source);
+      LibraryElement library = resolve2(source);
       CompilationUnit fullNewUnit = resolveCompilationUnit(source, library);
       // Validate tokens.
       _assertEqualTokens(newUnit, fullNewUnit);
       // Validate that "incremental" and "full" units have the same resolution.
       try {
         assertSameResolution(newUnit, fullNewUnit, validateTypes: true);
       } on IncrementalResolutionMismatch catch (mismatch) {
         fail(mismatch.message);
       }
       List<AnalysisError> newFullErrors =
@@ skipping 234 matching lines @@
     return ResolutionContextBuilder.contextFor(node, listener).scope;
   }
 }
 
 class _Edit {
   final int offset;
   final int length;
   final String replacement;
   _Edit(this.offset, this.length, this.replacement);
 }