Issue 1179253002: Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice.

Issue 1179253002: Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice. (Closed)

Created:
5 years, 6 months ago by scheglov

Modified:
5 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice. This fixes 11 tests in language/ and co19/. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/a16ec7749435d39d1cbc8cb58cc3f2fc66f5daad

Patch Set 2 : Return DART_ERRORS from getErrors() when valid. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -3 lines)			Patch
M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		3 chunks	+6 lines, -3 lines	0 comments	Download
M	pkg/analyzer/lib/src/task/dart_work_manager.dart	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	pkg/analyzer/test/src/task/dart_work_manager_test.dart	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1179253002/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart File pkg/analyzer/lib/src/task/dart_work_manager.dart (right): https://codereview.chromium.org/1179253002/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart#newcode44 pkg/analyzer/lib/src/task/dart_work_manager.dart:44: static final List<ResultDescriptor> _UNIT_ERRORS = <ResultDescriptor>[ I don't ...

5 years, 6 months ago (2015-06-12 19:27:48 UTC) #2

scheglov

https://codereview.chromium.org/1179253002/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart File pkg/analyzer/lib/src/task/dart_work_manager.dart (right): https://codereview.chromium.org/1179253002/diff/1/pkg/analyzer/lib/src/task/dart_work_manager.dart#newcode44 pkg/analyzer/lib/src/task/dart_work_manager.dart:44: static final List<ResultDescriptor> _UNIT_ERRORS = <ResultDescriptor>[ On 2015/06/12 19:27:48, ...

5 years, 6 months ago (2015-06-12 19:52:03 UTC) #3

scheglov

5 years, 6 months ago (2015-06-12 19:52:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
a16ec7749435d39d1cbc8cb58cc3f2fc66f5daad (presubmit successful).

Expand Messages | Collapse Messages