Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice.

pkg/analyzer/lib/src/task/dart_work_manager.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart_work_manager;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart'
@@ skipping 28 matching lines @@
   ];
 
   /**
    * The list of errors that are reported for raw Dart [LibrarySpecificUnit]s.
    */
   static final List<ResultDescriptor> _UNIT_ERRORS = <ResultDescriptor>[
     BUILD_FUNCTION_TYPE_ALIASES_ERRORS,
     HINTS,
     RESOLVE_REFERENCES_ERRORS,
     RESOLVE_TYPE_NAMES_ERRORS,
+    VARIABLE_REFERENCE_ERRORS,
     VERIFY_ERRORS
   ];
 
   final InternalAnalysisContext context;
 
   /**
    * The [TargetedResult]s that should be computed with priority.
    */
   final LinkedHashSet<TargetedResult> priorityResultQueue =
       new LinkedHashSet<TargetedResult>();
@@ skipping 113 matching lines @@
     }
   }
 
   /**
    * Return an [AnalysisErrorInfo] containing the list of all of the errors and
    * the line info associated with the given [source]. The list of errors will
    * be empty if the source is not known to the context or if there are no
    * errors in the source. The errors contained in the list can be incomplete.
    */
   AnalysisErrorInfo getErrors(Source source) {
+    if (analysisCache.getState(source, DART_ERRORS) == CacheState.VALID) {
+      List<AnalysisError> errors = analysisCache.getValue(source, DART_ERRORS);
+      LineInfo lineInfo = analysisCache.getValue(source, LINE_INFO);
+      return new AnalysisErrorInfoImpl(errors, lineInfo);
+    }
     List<AnalysisError> errors = <AnalysisError>[];
     for (ResultDescriptor descriptor in _SOURCE_ERRORS) {
       errors.addAll(analysisCache.getValue(source, descriptor));
     }
     for (Source library in context.getLibrariesContaining(source)) {
       LibrarySpecificUnit unit = new LibrarySpecificUnit(library, source);
       for (ResultDescriptor descriptor in _UNIT_ERRORS) {
         errors.addAll(analysisCache.getValue(unit, descriptor));
       }
     }
@@ skipping 246 matching lines @@
     }
   }
 
   bool _shouldErrorsBeComputed(Source source) =>
       context.shouldErrorsBeAnalyzed(source, null);
 
   static bool _isDartSource(AnalysisTarget target) {
     return target is Source && AnalysisEngine.isDartFileName(target.fullName);
   }
 }