Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice.

pkg/analyzer/lib/src/generated/incremental_resolver.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library engine.incremental_resolver;
 
 import 'dart:collection';
 import 'dart:math' as math;
 
 import 'package:analyzer/src/context/cache.dart'
     show CacheEntry, TargetedResult;
 import 'package:analyzer/src/generated/constant.dart';
 import 'package:analyzer/src/services/lint.dart';
 import 'package:analyzer/src/task/dart.dart'
     show
         HINTS,
         PARSE_ERRORS,
         RESOLVE_REFERENCES_ERRORS,
         RESOLVE_TYPE_NAMES_ERRORS,
         SCAN_ERRORS,
         USED_IMPORTED_ELEMENTS,
         USED_LOCAL_ELEMENTS,
+        VARIABLE_REFERENCE_ERRORS,
         VERIFY_ERRORS;
 import 'package:analyzer/task/dart.dart'
     show DART_ERRORS, LibrarySpecificUnit, PARSED_UNIT, TOKEN_STREAM;
 import 'package:analyzer/task/general.dart' show CONTENT;
 import 'package:analyzer/task/model.dart' show ResultDescriptor;
 
 import 'ast.dart';
 import 'element.dart';
 import 'engine.dart';
 import 'error.dart';
@@ skipping 1093 matching lines @@
 
   void _shiftEntryErrors() {
     if (oldEntry != null) {
       _shiftEntryErrors_OLD();
     } else {
       _shiftEntryErrors_NEW();
     }
   }
 
   void _shiftEntryErrors_NEW() {
+    _shiftErrors_NEW(HINTS);
+    _shiftErrors_NEW(RESOLVE_REFERENCES_ERRORS);
     _shiftErrors_NEW(RESOLVE_TYPE_NAMES_ERRORS);
-    _shiftErrors_NEW(RESOLVE_REFERENCES_ERRORS);
+    _shiftErrors_NEW(VARIABLE_REFERENCE_ERRORS);
     _shiftErrors_NEW(VERIFY_ERRORS);
-    _shiftErrors_NEW(HINTS);
   }
 
   void _shiftEntryErrors_OLD() {
     _shiftErrors_OLD(DartEntry.RESOLUTION_ERRORS);
     _shiftErrors_OLD(DartEntry.VERIFICATION_ERRORS);
     _shiftErrors_OLD(DartEntry.HINTS);
     _shiftErrors_OLD(DartEntry.LINTS);
   }
 
   void _shiftErrors(List<AnalysisError> errors) {
@@ skipping 28 matching lines @@
 
   void _updateEntry() {
     if (oldEntry != null) {
       _updateEntry_OLD();
     } else {
       _updateEntry_NEW();
     }
   }
 
   void _updateEntry_NEW() {
+    _updateErrors_NEW(RESOLVE_REFERENCES_ERRORS, _resolveErrors);
     _updateErrors_NEW(RESOLVE_TYPE_NAMES_ERRORS, []);
-    _updateErrors_NEW(RESOLVE_REFERENCES_ERRORS, _resolveErrors);
+    _updateErrors_NEW(VARIABLE_REFERENCE_ERRORS, []);
     _updateErrors_NEW(VERIFY_ERRORS, _verifyErrors);
     // invalidate results we don't update incrementally
     newUnitEntry.setState(USED_IMPORTED_ELEMENTS, CacheState.INVALID);
     newUnitEntry.setState(USED_LOCAL_ELEMENTS, CacheState.INVALID);
     newUnitEntry.setState(HINTS, CacheState.INVALID);
   }
 
   void _updateEntry_OLD() {
     {
       List<AnalysisError> oldErrors = oldEntry.getValueInLibrary(
@@ skipping 791 matching lines @@
   @override
   String toString() => name;
 }
 
 class _TokenPair {
   final _TokenDifferenceKind kind;
   final Token oldToken;
   final Token newToken;
   _TokenPair(this.kind, this.oldToken, this.newToken);
 }