Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice.

pkg/analyzer/lib/src/task/dart_work_manager.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library analyzer.src.task.dart_work_manager;
 
 import 'dart:collection';
 
 import 'package:analyzer/src/context/cache.dart';
 import 'package:analyzer/src/generated/engine.dart'
@@ skipping 23 matching lines @@
   static final List<ResultDescriptor> _SOURCE_ERRORS = <ResultDescriptor>[
     BUILD_DIRECTIVES_ERRORS,
     BUILD_LIBRARY_ERRORS,
     PARSE_ERRORS,
     SCAN_ERRORS
   ];
 
   /**
    * The list of errors that are reported for raw Dart [LibrarySpecificUnit]s.
    */
   static final List<ResultDescriptor> _UNIT_ERRORS = <ResultDescriptor>[

[Brian Wilkerson, 2015/06/12 19:27:48]

I don't like the fact that work manager has duplicated the list of errors that
need to be merged. Perhaps we could add comments to these lists and to the
corresponding tasks that point to each other so that we're less likely to only
update the list in one place.

[scheglov, 2015/06/12 19:52:03]

No changes for now.
But we now return DART_ERRORS when it is valid, so we eventually return the full
list of errors anyway.

     BUILD_FUNCTION_TYPE_ALIASES_ERRORS,
+    CONSTRUCTORS_ERRORS,
     HINTS,
     RESOLVE_REFERENCES_ERRORS,
     RESOLVE_TYPE_NAMES_ERRORS,
+    VARIABLE_REFERENCE_ERRORS,
     VERIFY_ERRORS
   ];
 
   final InternalAnalysisContext context;
 
   /**
    * The [TargetedResult]s that should be computed with priority.
    */
   final LinkedHashSet<TargetedResult> priorityResultQueue =
       new LinkedHashSet<TargetedResult>();
@@ skipping 379 matching lines @@
     }
   }
 
   bool _shouldErrorsBeComputed(Source source) =>
       context.shouldErrorsBeAnalyzed(source, null);
 
   static bool _isDartSource(AnalysisTarget target) {
     return target is Source && AnalysisEngine.isDartFileName(target.fullName);
   }
 }