Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1174173007: Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms. (Closed)

Created:
5 years, 6 months ago by rmacnak
Modified:
5 years, 6 months ago
Reviewers:
srdjan, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms. Remove misleading suffix from disassembly of some ia32 immediate ops. R=asiva@google.com, srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/b8bad6725cde94df97b3862e19b1cb45dd7a7379

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 11

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -85 lines) Patch
M runtime/platform/globals.h View 1 2 3 2 chunks +8 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm64.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 2 3 3 chunks +8 lines, -6 lines 0 comments Download
M runtime/vm/compiler_test.cc View 1 chunk +15 lines, -5 lines 0 comments Download
M runtime/vm/disassembler_ia32.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 2 3 10 chunks +27 lines, -23 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 3 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 9 chunks +21 lines, -18 lines 0 comments Download
M runtime/vm/raw_object.h View 1 2 1 chunk +14 lines, -1 line 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 1 6 chunks +12 lines, -23 lines 0 comments Download
M runtime/vm/snapshot.h View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
rmacnak
+6% Richards on i5 too
5 years, 6 months ago (2015-06-12 16:49:07 UTC) #2
srdjan
lgtm
5 years, 6 months ago (2015-06-12 17:48:07 UTC) #3
siva
LGTM with some comments. https://codereview.chromium.org/1174173007/diff/40001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/1174173007/diff/40001/runtime/vm/assembler_arm64.cc#newcode989 runtime/vm/assembler_arm64.cc:989: ASSERT(RawObject::kClassIdTagSize == 32); Use kBitsPerInt32 ...
5 years, 6 months ago (2015-06-12 22:08:11 UTC) #4
rmacnak
https://codereview.chromium.org/1174173007/diff/40001/runtime/vm/assembler_arm64.cc File runtime/vm/assembler_arm64.cc (right): https://codereview.chromium.org/1174173007/diff/40001/runtime/vm/assembler_arm64.cc#newcode989 runtime/vm/assembler_arm64.cc:989: ASSERT(RawObject::kClassIdTagSize == 32); On 2015/06/12 22:08:11, siva wrote: > ...
5 years, 6 months ago (2015-06-12 23:27:22 UTC) #5
rmacnak
5 years, 6 months ago (2015-06-12 23:42:45 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
b8bad6725cde94df97b3862e19b1cb45dd7a7379 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698