Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: runtime/vm/assembler_x64.cc

Issue 1174173007: Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_x64.cc
diff --git a/runtime/vm/assembler_x64.cc b/runtime/vm/assembler_x64.cc
index 6984fc3ab35c7a1507f1543830bc8be8cb632b77..3dcb7dfa69e2f22238a6de1e9560da8903cd1340 100644
--- a/runtime/vm/assembler_x64.cc
+++ b/runtime/vm/assembler_x64.cc
@@ -3745,11 +3745,12 @@ void Assembler::EmitGenericShift(bool wide,
void Assembler::LoadClassId(Register result, Register object) {
- ASSERT(RawObject::kClassIdTagPos == 16);
- ASSERT(RawObject::kClassIdTagSize == 16);
+ ASSERT(RawObject::kClassIdTagPos == kBitsPerInt32);
+ ASSERT(RawObject::kClassIdTagSize == kBitsPerInt32);
+ ASSERT(sizeof(classid_t) == sizeof(uint32_t));
const intptr_t class_id_offset = Object::tags_offset() +
RawObject::kClassIdTagPos / kBitsPerByte;
- movzxw(result, FieldAddress(object, class_id_offset));
+ movl(result, FieldAddress(object, class_id_offset));
}
@@ -3778,8 +3779,9 @@ void Assembler::SmiUntagOrCheckClass(Register object,
intptr_t class_id,
Label* is_smi) {
ASSERT(kSmiTagShift == 1);
- ASSERT(RawObject::kClassIdTagPos == 16);
- ASSERT(RawObject::kClassIdTagSize == 16);
+ ASSERT(RawObject::kClassIdTagPos == kBitsPerInt32);
+ ASSERT(RawObject::kClassIdTagSize == kBitsPerInt32);
+ ASSERT(sizeof(classid_t) == sizeof(uint32_t));
const intptr_t class_id_offset = Object::tags_offset() +
RawObject::kClassIdTagPos / kBitsPerByte;
@@ -3788,7 +3790,7 @@ void Assembler::SmiUntagOrCheckClass(Register object,
j(NOT_CARRY, is_smi, kNearJump);
// Load cid: can't use LoadClassId, object is untagged. Use TIMES_2 scale
// factor in the addressing mode to compensate for this.
- movzxw(TMP, Address(object, TIMES_2, class_id_offset));
+ movl(TMP, Address(object, TIMES_2, class_id_offset));
cmpl(TMP, Immediate(class_id));
}
« no previous file with comments | « runtime/vm/assembler_arm64.cc ('k') | runtime/vm/compiler_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698