Fix analyzer errors/warnings for Pub.

Fix analyzer errors/warnings for Pub.

Committed: https://code.google.com/p/dart/source/detail?r=16299

[Bob Nystrom, 2012-12-18 19:40:35]

I think I'd rather make separatorPattern a RegExp for now until the bug to move
those methods into Pattern is fixed. Otherwise, LGTM.

https://codereview.chromium.org/11609005/diff/1/utils/pub/http.dart
File utils/pub/http.dart (right):

https://codereview.chromium.org/11609005/diff/1/utils/pub/http.dart#newcode6
utils/pub/http.dart:6: library pub_http;
Do dotted identifiers work here yet? If not, add a TODO.

https://codereview.chromium.org/11609005/diff/1/utils/pub/path.dart
File utils/pub/path.dart (right):

https://codereview.chromium.org/11609005/diff/1/utils/pub/path.dart#newcode297
utils/pub/path.dart:297: if (part.length > 0 &&
part[0].contains(style.separatorPattern)) {
A simpler fix here is to just make separatorPattern a RegExp instead of a
Pattern.

[nweiz, 2012-12-19 01:10:21]

https://codereview.chromium.org/11609005/diff/1/utils/pub/http.dart
File utils/pub/http.dart (right):

https://codereview.chromium.org/11609005/diff/1/utils/pub/http.dart#newcode6
utils/pub/http.dart:6: library pub_http;
On 2012/12/18 19:40:35, Bob Nystrom wrote:
> Do dotted identifiers work here yet? If not, add a TODO.

The analyzer likes it and the tests run, so let's give it a shot.

https://codereview.chromium.org/11609005/diff/1/utils/pub/path.dart
File utils/pub/path.dart (right):

https://codereview.chromium.org/11609005/diff/1/utils/pub/path.dart#newcode297
utils/pub/path.dart:297: if (part.length > 0 &&
part[0].contains(style.separatorPattern)) {
On 2012/12/18 19:40:35, Bob Nystrom wrote:
> A simpler fix here is to just make separatorPattern a RegExp instead of a
> Pattern.

I think using str.contains(pattern) is about as clean as pattern.hasMatch(str),
so I'd like to keep the separator as a pattern. I'll change _rootPattern,
though, since faking firstMatch is pretty ugly.