Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: utils/pub/source.dart

Issue 11609005: Fix analyzer errors/warnings for Pub. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/pub/source.dart
diff --git a/utils/pub/source.dart b/utils/pub/source.dart
index b08647555e4556efae93e041f859de6513dabab4..1fcf9c87a5c140505559f4d50f83fa744a18fdc5 100644
--- a/utils/pub/source.dart
+++ b/utils/pub/source.dart
@@ -143,8 +143,10 @@ abstract class Source {
* This doesn't need to be implemented if [shouldCache] is false, or if
* [installToSystemCache] is implemented.
*/
- String systemCacheDirectory(PackageId id) =>
- join(systemCacheRoot, packageName(id.description));
+ String systemCacheDirectory(PackageId id) {
+ throw 'Source.systemCacheDirectory must be implemented if shouldCache is '
+ 'true and installToSystemCache is not implemented.';
+ }
/**
* When a [Pubspec] or [LockFile] is parsed, it reads in the description for
« utils/pub/path.dart ('K') | « utils/pub/path.dart ('k') | utils/pub/yaml/composer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698