Fix analyzer errors/warnings for Pub.

utils/pub/yaml/parser.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+part of yaml;
+
 /**
  * Translates a string of characters into a YAML serialization tree.
  *
  * This parser is designed to closely follow the spec. All productions in the
  * spec are numbered, and the corresponding methods in the parser have the same
  * numbers. This is certainly not the most efficient way of parsing YAML, but it
  * is the easiest to write and read in the context of the spec.
  *
  * Methods corresponding to productions are also named as in the spec,
  * translating the name of the method (although not the annotation characters)
@@ skipping 1783 matching lines @@
   // 198
   _Node s_l_blockInBlock(int indent, int ctx) => or([
     () => s_l_blockScalar(indent, ctx),
     () => s_l_blockCollection(indent, ctx)
   ]);
 
   // 199
   _Node s_l_blockScalar(int indent, int ctx) => transaction(() {
     if (!truth(s_separate(indent + 1, ctx))) return null;
     var props = transaction(() {
-      var props = c_ns_properties(indent + 1, ctx);
-      if (!truth(props)) return null;
+      var innerProps = c_ns_properties(indent + 1, ctx);
+      if (!truth(innerProps)) return null;
       if (!truth(s_separate(indent + 1, ctx))) return null;
-      return props;
+      return innerProps;
     });
 
     var node = or([() => c_l_literal(indent), () => c_l_folded(indent)]);
     if (!truth(node)) return null;
     return addProps(node, props);
   });
 
   // 200
   _Node s_l_blockCollection(int indent, int ctx) => transaction(() {
     var props = transaction(() {
@@ skipping 168 matching lines @@
       var pair = contents[i];
       if (pair.first.contains(pos)) return pair.last;
     }
     return null;
   }
 
   /** Associates [value] with [range]. */
   operator[]=(_Range range, E value) =>
     contents.add(new _Pair<_Range, E>(range, value));
 }