Fix analyzer errors/warnings for Pub.

utils/pub/path.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A comprehensive, cross-platform path manipulation library.
 library path;
 
 import 'dart:io' as io;
 
 /// An internal builder for the current OS so we can provide a straight
@@ skipping 276 matching lines @@
     }
 
     for (var part in parts) {
       if (part == null) continue;
 
       if (this.isAbsolute(part)) {
         // An absolute path discards everything before it.
         buffer.clear();
         buffer.add(part);
       } else {
-        if (part.length > 0 && style.separatorPattern.hasMatch(part[0])) {
+        if (part.length > 0 && part[0].contains(style.separatorPattern)) {

[Bob Nystrom, 2012/12/18 19:40:35]

A simpler fix here is to just make separatorPattern a RegExp instead of a
Pattern.

[nweiz, 2012/12/19 01:10:21]

I think using str.contains(pattern) is about as clean as pattern.hasMatch(str),
so I'd like to keep the separator as a pattern. I'll change _rootPattern,
though, since faking firstMatch is pretty ugly.

           // The part starts with a separator, so we don't need to add one.
         } else if (needsSeparator) {
           buffer.add(separator);
         }
 
         buffer.add(part);
       }
 
       // Unless this part ends with a separator, we'll need to add one before
       // the next part.
       needsSeparator = part.length > 0 &&
-          !style.separatorPattern.hasMatch(part[part.length - 1]);
+          !part[part.length - 1].contains(style.separatorPattern);
     }
 
     return buffer.toString();
   }
 
   // TODO(nweiz): add a UNC example for Windows once issue 7323 is fixed.
   /// Splits [path] into its components using the current platform's
   /// [separator]. Example:
   ///
   ///     builder.split('path/to/foo'); // -> ['path', 'to', 'foo']
@@ skipping 197 matching lines @@
   /// "\" is the canonical one.
   final Pattern separatorPattern;
 
   /// The [Pattern] that can be used to match the root prefix of an absolute
   /// path in this style.
   final Pattern _rootPattern;
 
   /// Gets the root prefix of [path] if path is absolute. If [path] is relative,
   /// returns `null`.
   String getRoot(String path) {
-    var match = _rootPattern.firstMatch(path);
-    if (match == null) return null;
-    return match[0];
+    var matches = _rootPattern.allMatches(path).iterator();
+    if (!matches.hasNext) return null;
+    return matches.next()[0];
   }
 
   String toString() => name;
 }
 
 // TODO(rnystrom): Make this public?
 class _ParsedPath {
   /// The [Style] that was used to parse this path.
   Style style;
 
@@ skipping 102 matching lines @@
 
     var lastDot = file.lastIndexOf('.');
 
     // If there is no dot, or it's the first character, like '.bashrc', it
     // doesn't count.
     if (lastDot <= 0) return [file, ''];
 
     return [file.substring(0, lastDot), file.substring(lastDot)];
   }
 }