Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1153193006: Standardize on using "kind" to distinguish sub-varieties of a type. (Closed)

Created:
5 years, 6 months ago by turnidge
Modified:
5 years, 6 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Standardize on using "kind" to distinguish sub-varieties of a type. - Event.eventType -> Event.kind. - Sentinel.id -> Sentinel.kind. We were already doing this for Code and will do so for Instance in an upcoming cl. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/ab6b2218b03fe57c6a401b10d99d89e041214cb5

Patch Set 1 #

Patch Set 2 : doc changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -96 lines) Patch
M runtime/observatory/lib/src/app/application.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 6 chunks +9 lines, -9 lines 0 comments Download
M runtime/observatory/lib/src/elements/heap_profile.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/lib/src/elements/isolate_summary.html View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 3 chunks +5 lines, -5 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 7 chunks +15 lines, -15 lines 0 comments Download
M runtime/observatory/tests/service/async_generator_breakpoint_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/break_on_activation_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/coverage_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugger_inspect_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/debugging_test.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M runtime/observatory/tests/service/echo_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/eval_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/evaluate_activation_test.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/observatory/tests/service/gc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/get_stack_rpc_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/isolate_lifecycle_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/source_location_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/steal_breakpoint_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/object_test.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/service.cc View 4 chunks +2 lines, -7 lines 0 comments Download
M runtime/vm/service/service.md View 1 10 chunks +22 lines, -13 lines 0 comments Download
M runtime/vm/service_event.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 6 months ago (2015-05-28 17:54:05 UTC) #2
Cutch
I like this. LGTM
5 years, 6 months ago (2015-05-28 17:57:47 UTC) #3
turnidge
5 years, 6 months ago (2015-05-28 18:04:36 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ab6b2218b03fe57c6a401b10d99d89e041214cb5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698