runtime/observatory/tests/service/steal_breakpoint_test.dart - Issue 1153193006: Standardize on using "kind" to distinguish sub-varieties of a type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/steal_breakpoint_test.dart

Issue 1153193006: Standardize on using "kind" to distinguish sub-varieties of a type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: doc changes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/observatory/tests/service/steal_breakpoint_test.dart

diff --git a/runtime/observatory/tests/service/steal_breakpoint_test.dart b/runtime/observatory/tests/service/steal_breakpoint_test.dart

index 702bf93318d08733d773c91bb21b65a8f3ddeacb..5efc7de52127d35dc517815b342e0f13caf35fba 100644

--- a/runtime/observatory/tests/service/steal_breakpoint_test.dart

+++ b/runtime/observatory/tests/service/steal_breakpoint_test.dart

@@ -31,7 +31,7 @@ var tests = [

Completer completer = new Completer();

var subscription;

subscription = isolate.vm.events.stream.listen((ServiceEvent event) {

- if (event.eventType == ServiceEvent.kPauseBreakpoint) {

+ if (event.kind == ServiceEvent.kPauseBreakpoint) {

print('Isolate paused at breakpoint');

subscription.cancel();

completer.complete();

@@ -63,7 +63,7 @@ var tests = [

Completer completer = new Completer();

var subscription;

subscription = isolate.vm.events.stream.listen((ServiceEvent event) {

- if (event.eventType == ServiceEvent.kResume) {

+ if (event.kind == ServiceEvent.kResume) {

print('Isolate resumed');

subscription.cancel();

completer.complete();