Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1838)

Unified Diff: runtime/observatory/tests/service/isolate_lifecycle_test.dart

Issue 1153193006: Standardize on using "kind" to distinguish sub-varieties of a type. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: doc changes Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/isolate_lifecycle_test.dart
diff --git a/runtime/observatory/tests/service/isolate_lifecycle_test.dart b/runtime/observatory/tests/service/isolate_lifecycle_test.dart
index be878a222ca6b9aa714ae88f93bdca806ef724e1..318013706ab094fe287449d40e796c4a9840de83 100644
--- a/runtime/observatory/tests/service/isolate_lifecycle_test.dart
+++ b/runtime/observatory/tests/service/isolate_lifecycle_test.dart
@@ -55,7 +55,7 @@ var tests = [
// Wait for the testee to start all of the isolates.
if (vm.isolates.length != spawnCount + 1) {
await processServiceEvents(vm, (event, sub, completer) {
- if (event.eventType == ServiceEvent.kIsolateStart) {
+ if (event.kind == ServiceEvent.kIsolateStart) {
if (vm.isolates.length == spawnCount + 1) {
sub.cancel();
completer.complete(null);
@@ -77,7 +77,7 @@ var tests = [
// Wait for all spawned isolates to hit pause-at-exit.
if (numPaused(vm) != spawnCount) {
await processServiceEvents(vm, (event, sub, completer) {
- if (event.eventType == ServiceEvent.kPauseExit) {
+ if (event.kind == ServiceEvent.kPauseExit) {
if (numPaused(vm) == spawnCount) {
sub.cancel();
completer.complete(null);
@@ -93,7 +93,7 @@ var tests = [
(VM vm) async {
var resumedReceived = 0;
var eventsDone = processServiceEvents(vm, (event, sub, completer) {
- if (event.eventType == ServiceEvent.kIsolateExit) {
+ if (event.kind == ServiceEvent.kIsolateExit) {
resumedReceived++;
if (resumedReceived == resumeCount) {
sub.cancel();
« no previous file with comments | « runtime/observatory/tests/service/get_stack_rpc_test.dart ('k') | runtime/observatory/tests/service/source_location_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698