Issue 11418173: Canonicalize raw type

Issue 11418173: Canonicalize raw type (Closed)

Created:
8 years ago by Johnni Winther

Modified:
8 years ago

Reviewers:
ahe, karlklose, ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Canonicalize raw type Committed: https://code.google.com/p/dart/source/detail?r=15441

Patch Set 3 : Backend updated to use isRaw #

Patch Set 5 : Bring isRaw in alignment with asRaw. #

Total comments: 5

Patch Set 6 : Updated cf. comments. #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+145 lines, -55 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/elements/elements.dart	View	1 2 3 4	6 chunks	+69 lines, -10 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/enqueue.dart	View	1 2 3 4	2 chunks	+8 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart	View	1 2	2 chunks	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart	View	1 2 3	1 chunk	+7 lines, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/native_handler.dart	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1 2 3 4 5	4 chunks	+13 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1 2 3 4 5	5 chunks	+9 lines, -3 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/codegen.dart	View	1 2	1 chunk	+10 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/typechecker.dart	View	1 2 3 4	9 chunks	+20 lines, -11 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/world.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

DBC https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler/implementation/native_handler.dart File sdk/lib/_internal/compiler/implementation/native_handler.dart (right): https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler/implementation/native_handler.dart#newcode239 sdk/lib/_internal/compiler/implementation/native_handler.dart:239: (nativeClass) => compiler.types.isSubtype(nativeClass.thisType, type), line too long https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler/implementation/ssa/builder.dart ...

8 years ago (2012-11-27 12:30:15 UTC) #2

karlklose

LGTM. https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler/implementation/native_handler.dart File sdk/lib/_internal/compiler/implementation/native_handler.dart (right): https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler/implementation/native_handler.dart#newcode239 sdk/lib/_internal/compiler/implementation/native_handler.dart:239: (nativeClass) => compiler.types.isSubtype(nativeClass.thisType, type), Long line, but you ...

8 years ago (2012-11-28 08:02:32 UTC) #3

Johnni Winther

8 years ago (2012-11-28 08:18:38 UTC) #4

https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:239: (nativeClass)
 => compiler.types.isSubtype(nativeClass.thisType, type),
On 2012/11/27 12:30:15, ngeoffray wrote:
> line too long

Done.

https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11418173/diff/5001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/ssa/builder.dart:3063: if (argument ==
compiler.types.dynamicType) {
On 2012/11/27 12:30:15, ngeoffray wrote:
> Please add a comment here.

Done.

https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/native_handler.dart (right):

https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/native_handler.dart:239: (nativeClass)
 => compiler.types.isSubtype(nativeClass.thisType, type),
On 2012/11/28 08:02:32, karlklose wrote:
> Long line, but you can fix it by deleting one of the spaces before =>.

Done.

https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/resolution/members.dart (right):

https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1131:
cls.computeType(compiler);
On 2012/11/28 08:02:32, karlklose wrote:
> Before this change, the type was computed lazily when calling computeType.
Now,
> we have the invariant that computeType must be called before rawType can be
> accessed.
> 
> Perhaps we should always call compute type when we resolve a class?

We do. The call to computeType is not currently needed when we call
ensureResolved.

https://codereview.chromium.org/11418173/diff/6013/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/resolution/members.dart:1158:
typdef.computeType(compiler);
Not needed either since we call [resolveTypedef].

Expand Messages | Collapse Messages