sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart - Issue 11418173: Canonicalize raw type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 11418173: Canonicalize raw type (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart ('k') | sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

diff --git a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

index 63e14f98b8b68d83ea3b786189df6a695c5516bf..93262f8a178fce7b3124af69a839a76a986a2954 100644

--- a/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

+++ b/sdk/lib/_internal/compiler/implementation/dart_backend/placeholder_collector.dart

@@ -174,14 +174,14 @@ class PlaceholderCollector extends Visitor {

void collectFunctionDeclarationPlaceholders(

FunctionElement element, FunctionExpression node) {

if (element.isGenerativeConstructor() || element.isFactoryConstructor()) {

- DartType type = element.getEnclosingClass().type.asRaw();

+ DartType type = element.getEnclosingClass().thisType.asRaw();

makeConstructorPlaceholder(node.name, element, type);

Return bodyAsReturn = node.body.asReturn();

if (bodyAsReturn != null && bodyAsReturn.isRedirectingFactoryBody) {

// Factory redirection.

FunctionElement redirectTarget = element.defaultImplementation;

assert(redirectTarget != null && redirectTarget != element);

- type = redirectTarget.getEnclosingClass().type.asRaw();

+ type = redirectTarget.getEnclosingClass().thisType.asRaw();

makeConstructorPlaceholder(

bodyAsReturn.expression, redirectTarget, type);

}