sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart - Issue 11418173: Canonicalize raw type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 11418173: Canonicalize raw type (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart ('k') | sdk/lib/_internal/compiler/implementation/native_handler.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

index 721c9adefdf187e63849b41d4086acb974fac1a4..a5ee505b4d90cce3f327f8730186ff0567fd1640 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

@@ -1171,11 +1171,13 @@ class Dart2JsInterfaceTypeMirror extends Dart2JsTypeElementMirror

List<TypeMirror> get typeArguments {

if (_typeArguments == null) {

_typeArguments = <TypeMirror>[];

- Link<DartType> type = _interfaceType.typeArguments;

- while (type != null && type.head != null) {

- _typeArguments.add(_convertTypeToTypeMirror(mirrors, type.head,

- mirrors.compiler.types.dynamicType));

- type = type.tail;

+ if (!_interfaceType.isRaw) {

+ Link<DartType> type = _interfaceType.typeArguments;

+ while (type != null && type.head != null) {

+ _typeArguments.add(_convertTypeToTypeMirror(mirrors, type.head,

+ mirrors.compiler.types.dynamicType));

+ type = type.tail;

+ }

}

return _typeArguments;