sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart - Issue 11418173: Canonicalize raw type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

Issue 11418173: Canonicalize raw type (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Updated cf. comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/enqueue.dart ('k') | sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

index 2064f0948462af1fcc7431bdc93b563a37ed24da..a4545e6e26259dd8e7aed34f008848a22bb26a45 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart

@@ -23,11 +23,10 @@ class RuntimeTypeInformation {

InterfaceType interface = t;

ClassElement element = t.element;

if (element.typeVariables.isEmpty) return;

- bool isRaw = interface.typeArguments.isEmpty;

+ bool isRaw = interface.isRaw;

if (isRaw && !expandRawType) return;

builder.add('<');

- Iterable items =

- isRaw ? element.typeVariables : interface.typeArguments;

+ Iterable items = interface.typeArguments;

var stringify = isRaw ? (_) => 'dynamic' : (type) => type.toString();

bool first = true;

for (var item in items) {

@@ -49,7 +48,7 @@ class RuntimeTypeInformation {

static bool hasTypeArguments(DartType type) {

if (type is InterfaceType) {

InterfaceType interfaceType = type;

- return !interfaceType.typeArguments.isEmpty;

+ return !interfaceType.isRaw;

}

return false;

}