Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 1130773002: Differentiate between unresolved class and constructor. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org, Anders Johnsen
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Differentiate between unresolved class and constructor. BUG= R=asgerf@google.com Committed: https://code.google.com/p/dart/source/detail?r=45591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -111 lines) Patch
M pkg/compiler/lib/src/resolution/access_semantics.dart View 2 chunks +23 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 6 chunks +26 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 11 chunks +116 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +13 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 17 chunks +38 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-05-06 13:36:48 UTC) #2
asgerf
LGTM
5 years, 7 months ago (2015-05-06 15:16:15 UTC) #3
asgerf
On 2015/05/06 15:16:15, asgerf wrote: > LGTM Ping. Could really use this.
5 years, 7 months ago (2015-05-07 11:22:47 UTC) #4
Johnni Winther
5 years, 7 months ago (2015-05-07 13:03:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 45591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698