Differentiate between unresolved class and constructor.

pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor;
 
 /// Interface for bulk handling of a [Node] in a semantic visitor.
 abstract class BulkHandle<R, A> {
   /// Handle [node] either regardless of semantics or to report that [node] is
   /// unhandled. [message] contains a message template for the latter case:
@@ skipping 15 matching lines @@
 
   @override
   R errorInvalidAssert(
       Send node,
       NodeList arguments,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
-  R errorAbstractClassConstructorInvoke(
-      NewExpression node,
-      ConstructorElement element,
-      InterfaceType type,
-      NodeList arguments,
-      CallStructure callStructure,
-      A arg) {
-    return bulkHandleError(node, arg);
-  }
-
-  @override
   R errorClassTypeLiteralCompound(
       Send node,
       ConstantExpression constant,
       AssignmentOperator operator,
       Node rhs,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
@@ skipping 187 matching lines @@
   @override
   R errorLocalFunctionSet(
       SendSet node,
       LocalFunctionElement function,
       Node rhs,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
+  R errorNonConstantConstructorInvoke(
+      NewExpression node,
+      Element element,
+      InterfaceType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg) {
+    return bulkHandleError(node, arg);
+  }
+
+  @override
   R errorStaticFunctionSet(
       Send node,
       MethodElement function,
       Node rhs,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
   R errorStaticGetterSet(
@@ skipping 172 matching lines @@
   R errorUnresolvedCompound(
       Send node,
       Element element,
       AssignmentOperator operator,
       Node rhs,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
-  R errorUnresolvedClassConstructorInvoke(
-      NewExpression node,
-      Element element,
-      MalformedType type,
-      NodeList arguments,
-      Selector selector,
-      A arg) {
-    return bulkHandleError(node, arg);
-  }
-
-  @override
-  R errorUnresolvedConstructorInvoke(
-      NewExpression node,
-      Element constructor,
-      DartType type,
-      NodeList arguments,
-      Selector selector,
-      A arg) {
-    return bulkHandleError(node, arg);
-  }
-
-  @override
   R errorUnresolvedPostfix(
       Send node,
       Element element,
       IncDecOperator operator,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
   R errorUnresolvedPrefix(
       Send node,
       Element element,
       IncDecOperator operator,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
-  R errorUnresolvedRedirectingFactoryConstructorInvoke(
-       NewExpression node,
-       ConstructorElement constructor,
-       InterfaceType type,
-       NodeList arguments,
-       Selector selector,
-       A arg) {
-    return bulkHandleError(node, arg);
-  }
-
-  @override
   R errorUnresolvedSet(
       Send node,
       Element element,
       Node rhs,
       A arg) {
     return bulkHandleError(node, arg);
   }
 
   @override
   R errorUnresolvedSuperCompoundIndexSet(
@@ skipping 1828 matching lines @@
 
 abstract class NewBulkMixin<R, A>
     implements SemanticSendVisitor<R, A>, BulkHandle<R, A> {
 
   R bulkHandleNew(NewExpression node, A arg) {
     return bulkHandleNode(
         node, "Constructor invocation `#` unhandled.", arg);
   }
 
   @override
+  R visitAbstractClassConstructorInvoke(
+      NewExpression node,
+      ConstructorElement element,
+      InterfaceType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg) {
+    return bulkHandleNew(node, arg);
+  }
+
+  @override
   R visitConstConstructorInvoke(
       NewExpression node,
       ConstructedConstantExpression constant,
       A arg) {
     return bulkHandleNew(node, arg);
   }
 
   R visitGenerativeConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
@@ skipping 28 matching lines @@
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       ConstructorElement effectiveTarget,
       InterfaceType effectiveTargetType,
       NodeList arguments,
       CallStructure callStructure,
       A arg) {
     return bulkHandleNew(node, arg);
   }
+
+  @override
+  R visitUnresolvedClassConstructorInvoke(
+      NewExpression node,
+      Element element,
+      DartType type,
+      NodeList arguments,
+      Selector selector,
+      A arg) {
+    return bulkHandleNew(node, arg);
+  }
+
+  @override
+  R visitUnresolvedConstructorInvoke(
+      NewExpression node,
+      Element constructor,
+      DartType type,
+      NodeList arguments,
+      Selector selector,
+      A arg) {
+    return bulkHandleNew(node, arg);
+  }
+
+  @override
+  R visitUnresolvedRedirectingFactoryConstructorInvoke(
+       NewExpression node,
+       ConstructorElement constructor,
+       InterfaceType type,
+       NodeList arguments,
+       CallStructure callStructure,
+       A arg) {
+    return bulkHandleNew(node, arg);
+  }
 }
 
 /// Visitor that implements [SemanticSendVisitor] by the use of `BulkX` mixins.
 ///
 /// This class is useful in itself, but shows how to use the `BulkX` mixins and
 /// tests that the union of the `BulkX` mixins implement all `visit` and `error`
 /// methods of [SemanticSendVisitor].
 class BulkSendVisitor<R, A> extends SemanticSendVisitor<R, A>
     with GetBulkMixin<R, A>,
          SetBulkMixin<R, A>,
@@ skipping 2388 matching lines @@
   }
 
   R visitConstConstructorInvoke(
       NewExpression node,
       ConstructedConstantExpression constant,
       A arg) {
     return null;
   }
 
   @override
-  R errorUnresolvedClassConstructorInvoke(
+  R visitUnresolvedClassConstructorInvoke(
       NewExpression node,
       Element constructor,
-      MalformedType type,
+      DartType type,
       NodeList arguments,
       Selector selector,
       A arg) {
     apply(arguments, arg);
     return null;
   }
 
   @override
-  R errorUnresolvedConstructorInvoke(
+  R visitUnresolvedConstructorInvoke(
       NewExpression node,
       Element constructor,
       DartType type,
       NodeList arguments,
       Selector selector,
       A arg) {
     apply(arguments, arg);
     return null;
   }
 
@@ skipping 41 matching lines @@
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
       CallStructure callStructure,
       A arg) {
     apply(arguments, arg);
     return null;
   }
 
   @override
-  R errorAbstractClassConstructorInvoke(
+  R visitAbstractClassConstructorInvoke(
       NewExpression node,
       ConstructorElement element,
       InterfaceType type,
       NodeList arguments,
       CallStructure callStructure,
       A arg) {
     apply(arguments, arg);
     return null;
   }
 
   @override
-  R errorUnresolvedRedirectingFactoryConstructorInvoke(
+  R visitUnresolvedRedirectingFactoryConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
-      Selector selector,
+      CallStructure callStructure,
       A arg) {
     apply(arguments, arg);
     return null;
+  }
+
+  @override
+  R errorNonConstantConstructorInvoke(
+      NewExpression node,
+      Element element,
+      InterfaceType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg) {
+    apply(arguments, arg);
+    return null;
   }
 }
 
 /// [SemanticDeclarationVisitor] that visits subnodes.
 class TraversalDeclarationMixin<R, A>
     implements SemanticDeclarationVisitor<R, A> {
   @override
   R apply(Node node, A arg) {
     throw new UnimplementedError("TraversalMixin.apply unimplemented");
   }
@@ skipping 1683 matching lines @@
       ConstructorElement constructor,
       InterfaceType type,
       ConstructorElement effectiveTarget,
       InterfaceType effectiveTargetType,
       NodeList arguments,
       CallStructure callStructure,
       A arg) {
     return handleConstructorInvoke(
         node, constructor, type, arguments, callStructure, arg);
   }
+
+  R visitUnresolvedConstructorInvoke(
+      NewExpression node,
+      Element constructor,
+      DartType type,
+      NodeList arguments,
+      Selector selector,
+      A arg) {
+    return handleConstructorInvoke(
+        node, constructor, type, arguments, selector.callStructure, arg);
+  }
+
+  R visitUnresolvedClassConstructorInvoke(
+      NewExpression node,
+      Element element,
+      DartType type,
+      NodeList arguments,
+      Selector selector,
+      A arg) {
+    return handleConstructorInvoke(
+        node, element, type, arguments, selector.callStructure, arg);
+  }
+
+  R visitAbstractClassConstructorInvoke(
+      NewExpression node,
+      ConstructorElement constructor,
+      InterfaceType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg) {
+    return handleConstructorInvoke(
+        node, constructor, type, arguments, callStructure, arg);
+  }
+  R visitUnresolvedRedirectingFactoryConstructorInvoke(
+      NewExpression node,
+      ConstructorElement constructor,
+      InterfaceType type,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg) {
+    return handleConstructorInvoke(
+        node, constructor, type, arguments, callStructure, arg);
+  }
 }