Differentiate between unresolved class and constructor.

tests/compiler/dart2js/semantic_visitor_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor_test;
 
 import 'dart:async';
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
 import 'package:compiler/src/constants/expressions.dart';
@@ skipping 2250 matching lines @@
             targetType: 'Class<Class<int>>',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           Class(a, b);
         }
         m() => new Class.unresolved(true, 42);
         ''',
         const Visit(
-            VisitKind.ERROR_UNRESOLVED_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
             arguments: '(true,42)')),
     const Test(
         '''
         m() => new Unresolved(true, 42);
         ''',
         const Visit(
-            // TODO(johnniwinther): Update this to
-            // `VisitKind.ERROR_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE`.
-            VisitKind.ERROR_UNRESOLVED_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
             arguments: '(true,42)')),
     const Test(
         '''
         abstract class AbstractClass {}
         m() => new AbstractClass();
         ''',
         const Visit(
-            VisitKind.ERROR_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
             element: 'generative_constructor(AbstractClass#)',
             type: 'AbstractClass',
             arguments: '()',
             selector: 'CallStructure(arity=0)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Unresolved;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
-            VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
-            selector: 'Selector(call, , arity=2)')),
+            selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Class.named;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
-            VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
-            selector: 'Selector(call, , arity=2)')),
+            selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
           factory Class(a, b) = Class.named;
           factory Class.named(a, b) = Class.unresolved;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
-            VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
-            selector: 'Selector(call, , arity=2)')),
+            selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         abstract class AbstractClass {
           AbstractClass(a, b);
         }
         class Class {
           factory Class(a, b) = AbstractClass;
         }
         m() => new Class(true, 42);
         ''',
         const Visit(
-            VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+            VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
-            selector: 'Selector(call, , arity=2)')),
+            selector: 'CallStructure(arity=2)')),
   ],
 };
 
 const Map<String, List<Test>> DECL_TESTS = const {
   'Function declarations': const [
     const Test(
         '''
         m(a, b) {}
         ''',
         const [
@@ skipping 2913 matching lines @@
       Node index,
       IncDecOperator operator,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_SUPER_INDEX_PREFIX,
         getter: indexFunction, setter: indexSetFunction,
         index: index, operator: operator));
     apply(index, arg);
   }
 
   @override
-  errorUnresolvedClassConstructorInvoke(
-      NewExpression node,
-      Element constructor,
-      MalformedType type,
-      NodeList arguments,
-      Selector selector,
-      arg) {
-    // TODO(johnniwinther): Test [type] and [selector].
-    visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
-        arguments: arguments));
-    apply(arguments, arg);
-  }
-
-  @override
-  errorUnresolvedConstructorInvoke(
+  visitUnresolvedClassConstructorInvoke(
       NewExpression node,
       Element constructor,
       DartType type,
       NodeList arguments,
       Selector selector,
       arg) {
-    // TODO(johnniwinther): Test [type] and [selector].
+    // TODO(johnniwinther): Test [type] when it is not `dynamic`.
     visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
         arguments: arguments));
     apply(arguments, arg);
   }
+
+  @override
+  visitUnresolvedConstructorInvoke(
+      NewExpression node,
+      Element constructor,
+      DartType type,
+      NodeList arguments,
+      Selector selector,
+      arg) {
+    // TODO(johnniwinther): Test [type] when it is not `dynamic`.
+    visits.add(new Visit(
+        VisitKind.VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
+        arguments: arguments));
+    apply(arguments, arg);
+  }
 
   @override
   visitConstConstructorInvoke(
       NewExpression node,
       ConstructedConstantExpression constant,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_CONST_CONSTRUCTOR_INVOKE,
                          constant: constant.getText()));
   }
 
@@ skipping 63 matching lines @@
     visits.add(new Visit(
         VisitKind.VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
         selector: callStructure));
     apply(arguments, arg);
   }
 
   @override
-  errorAbstractClassConstructorInvoke(
+  visitAbstractClassConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(
-        VisitKind.ERROR_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
         selector: callStructure));
     apply(arguments, arg);
   }
 
   @override
-  errorUnresolvedRedirectingFactoryConstructorInvoke(
+  visitUnresolvedRedirectingFactoryConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
-      Selector selector,
+      CallStructure callStructure,
       arg) {
     visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
-        selector: selector));
+        selector: callStructure));
     apply(arguments, arg);
   }
 }
 
 class SemanticDeclarationTestVisitor extends SemanticTestVisitor {
 
   SemanticDeclarationTestVisitor(TreeElements elements) : super(elements);
 
   @override
   errorUnresolvedSuperConstructorInvoke(
@@ skipping 462 matching lines @@
       Node body,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_SETTER_DECL,
         element: setter, parameters: parameters, body: body));
     applyParameters(parameters, arg);
     apply(body, arg);
     return null;
   }
 
   @override
-  errorUnresolvedClassConstructorInvoke(
+  visitUnresolvedClassConstructorInvoke(
       NewExpression node,
       Element constructor,
       MalformedType type,
       NodeList arguments,
       Selector selector,
       arg) {
     // TODO(johnniwinther): Test [type] and [selector].
     visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
         arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
-  errorUnresolvedConstructorInvoke(
+  visitUnresolvedConstructorInvoke(
       NewExpression node,
       Element constructor,
       DartType type,
       NodeList arguments,
       Selector selector,
       arg) {
     // TODO(johnniwinther): Test [type] and [selector].
     visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
         arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
   visitConstConstructorInvoke(
       NewExpression node,
       ConstructedConstantExpression constant,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_CONST_CONSTRUCTOR_INVOKE,
@@ skipping 66 matching lines @@
     visits.add(new Visit(
         VisitKind.VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
         selector: callStructure));
     apply(arguments, arg);
   }
 
   @override
-  errorAbstractClassConstructorInvoke(
+  visitAbstractClassConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(
-        VisitKind.ERROR_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
         selector: callStructure));
     apply(arguments, arg);
   }
 
   @override
-  errorUnresolvedRedirectingFactoryConstructorInvoke(
+  visitUnresolvedRedirectingFactoryConstructorInvoke(
       NewExpression node,
       ConstructorElement constructor,
       InterfaceType type,
       NodeList arguments,
-      Selector selector,
+      CallStructure callStructure,
       arg) {
     visits.add(new Visit(
-        VisitKind.ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+        VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
         element: constructor,
         type: type,
         arguments: arguments,
-        selector: selector));
+        selector: callStructure));
     apply(arguments, arg);
   }
 }
 
 enum VisitKind {
   VISIT_PARAMETER_GET,
   VISIT_PARAMETER_SET,
   VISIT_PARAMETER_INVOKE,
   VISIT_PARAMETER_COMPOUND,
   VISIT_PARAMETER_PREFIX,
@@ skipping 176 matching lines @@
   VISIT_CONST_CONSTRUCTOR_INVOKE,
   VISIT_GENERATIVE_CONSTRUCTOR_INVOKE,
   VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_INVOKE,
   VISIT_FACTORY_CONSTRUCTOR_INVOKE,
   VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
 
   VISIT_SUPER_CONSTRUCTOR_INVOKE,
   VISIT_THIS_CONSTRUCTOR_INVOKE,
   VISIT_FIELD_INITIALIZER,
 
-  ERROR_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
-  ERROR_UNRESOLVED_CONSTRUCTOR_INVOKE,
-  ERROR_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
-  ERROR_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
+  VISIT_UNRESOLVED_CLASS_CONSTRUCTOR_INVOKE,
+  VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
+  VISIT_ABSTRACT_CLASS_CONSTRUCTOR_INVOKE,
+  VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
 
   VISIT_INSTANCE_GETTER_DECL,
   VISIT_INSTANCE_SETTER_DECL,
   VISIT_INSTANCE_METHOD_DECL,
   VISIT_ABSTRACT_GETTER_DECL,
   VISIT_ABSTRACT_SETTER_DECL,
   VISIT_ABSTRACT_METHOD_DECL,
   VISIT_INSTANCE_FIELD_DECL,
 
   VISIT_GENERATIVE_CONSTRUCTOR_DECL,
   VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_DECL,
   VISIT_FACTORY_CONSTRUCTOR_DECL,
   VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_DECL,
 
   VISIT_REQUIRED_PARAMETER_DECL,
   VISIT_OPTIONAL_PARAMETER_DECL,
   VISIT_NAMED_PARAMETER_DECL,
   VISIT_REQUIRED_INITIALIZING_FORMAL_DECL,
   VISIT_OPTIONAL_INITIALIZING_FORMAL_DECL,
   VISIT_NAMED_INITIALIZING_FORMAL_DECL,
 
   ERROR_UNRESOLVED_POSTFIX,
 
   // TODO(johnniwinther): Add tests for more error cases.
 }