Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Unified Diff: pkg/compiler/lib/src/resolution/send_structure.dart

Issue 1130773002: Differentiate between unresolved class and constructor. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/send_structure.dart
diff --git a/pkg/compiler/lib/src/resolution/send_structure.dart b/pkg/compiler/lib/src/resolution/send_structure.dart
index 475451f23fa7a9a8a52ac5e9134899b2442e7443..35cdaa31c59ef9ada7cdbe59cb56865c2211e272 100644
--- a/pkg/compiler/lib/src/resolution/send_structure.dart
+++ b/pkg/compiler/lib/src/resolution/send_structure.dart
@@ -1937,17 +1937,25 @@ class NewInvokeStructure<R, A> extends NewStructure<R, A> {
semantics.effectiveTargetSemantics.type,
node.send.argumentsNode, callStructure, arg);
case ConstructorAccessKind.ABSTRACT:
- return visitor.errorAbstractClassConstructorInvoke(
+ return visitor.visitAbstractClassConstructorInvoke(
node, semantics.element, semantics.type,
node.send.argumentsNode, callStructure, arg);
- case ConstructorAccessKind.ERRONEOUS:
- return visitor.errorUnresolvedConstructorInvoke(
+ case ConstructorAccessKind.UNRESOLVED_CONSTRUCTOR:
+ return visitor.visitUnresolvedConstructorInvoke(
node, semantics.element, semantics.type,
node.send.argumentsNode, selector, arg);
- case ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY:
- return visitor.errorUnresolvedRedirectingFactoryConstructorInvoke(
+ case ConstructorAccessKind.UNRESOLVED_TYPE:
+ return visitor.visitUnresolvedClassConstructorInvoke(
node, semantics.element, semantics.type,
node.send.argumentsNode, selector, arg);
+ case ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR:
+ return visitor.errorNonConstantConstructorInvoke(
+ node, semantics.element, semantics.type,
+ node.send.argumentsNode, callStructure, arg);
+ case ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY:
+ return visitor.visitUnresolvedRedirectingFactoryConstructorInvoke(
+ node, semantics.element, semantics.type,
+ node.send.argumentsNode, callStructure, arg);
}
throw new SpannableAssertionFailure(node,
"Unhandled constructor invocation kind: ${semantics.kind}");
« no previous file with comments | « pkg/compiler/lib/src/resolution/send_resolver.dart ('k') | tests/compiler/dart2js/semantic_visitor_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698