Fix super ==: Test first for null before call inf super ==.

Fix super ==: Test first for null before call inf super ==.
Committed: https://code.google.com/p/dart/source/detail?r=13907

[hausner, 2012-10-22 20:00:29]

LGTM. I'm happy to do the == as symbol part after you check this in as is.

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.cc (right):

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.cc:1856: const String& equality_name =
String::Handle(Symbols::New("=="));
Ditto regarding using a symbol.

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:3372: const String& equality_name =
String::Handle(Symbols::New("=="));
I expect this will be called quite often. It might be beneficial to allocate the
string "==" in the symbol table instead of creating a new one each time (and
then throwing it away during canonicalization).

[srdjan, 2012-10-22 20:30:51]

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/11230034/diff/8002/runtime/vm/object.cc#newco...
runtime/vm/object.cc:3372: const String& equality_name =
String::Handle(Symbols::New("=="));
On 2012/10/22 20:00:29, hausner wrote:
> I expect this will be called quite often. It might be beneficial to allocate
the
> string "==" in the symbol table instead of creating a new one each time (and
> then throwing it away during canonicalization).

Symbols::New does not create new symbol each time, but returns one if it already
exists in the symbol table.